Skip to content

Conversation

@Hritik003
Copy link

Description:
This pull request adds support for specifying ImagePullSecrets in the OpenTelemetry Collector Kubernetes resources, allowing users to configure secrets for pulling container images from private registries. The implementation includes updates to the API, resource generation logic, and comprehensive unit tests to verify the new functionality.

API and Struct Enhancements:

  • Added an ImagePullSecrets field to the OpenTelemetryCommonFields struct, enabling users to specify secrets for image pulls in the custom resource definition.
  • Updated the autogenerated DeepCopyInto method to handle deep copying of the new ImagePullSecrets field.

Resource Generation Updates:

  • Modified the Deployment, DaemonSet, and StatefulSet manifest generation functions to set the ImagePullSecrets field in the resulting Kubernetes resource specs, based on the custom resource configuration. [1] [2] [3]

Testing Improvements:

Testing:

Documentation:

@Hritik003 Hritik003 requested a review from a team as a code owner September 23, 2025 07:00
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 23, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Hritik003 / name: Hritik Raj (c3373fc)

@Hritik003 Hritik003 changed the title add image pull secrets in all otel collector spec add image pull secrets in otel collector spec Sep 23, 2025
@Hritik003 Hritik003 marked this pull request as draft September 23, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Image pull secret in the open telemetry collector spec

1 participant