bluetooth/tools: add BREDR GATT service in gatt_server tool#542
Merged
Conversation
liuX10
requested review from
chengkai15,
gzh-terry,
huangyulong3,
hyson710,
zhangyuan376 and
zhongzhijie1
as code owners
chengkai15
approved these changes
Mar 27, 2026
Contributor
chengkai15
left a comment
chengkai15
left a comment
There was a problem hiding this comment.
PR #542 Review — add BREDR GATT service in gatt_server tool
概述： 1 文件 50+/2-，添加 BR/EDR GATT 测试服务（UUID 0xFF10），用于 PTS cross-transport 测试。仅工具代码，不影响生产。
✅ 优点
- PR 描述清晰完整（Summary/Impact/Testing）
- 遵循现有服务模式（DIS/BAS/CUSTOM/BREDR）
GATT_H_PRIMARY_SERVICE_OVER_BREDR宏正确用于 cross-transport 注册- Vendor-specific UUID 0xFF10-0xFF12 使用正确
📋 结论
工具级改动，用途明确。APPROVE
zhongzhijie1
approved these changes
Apr 2, 2026
Contributor
zhongzhijie1
left a comment
zhongzhijie1
left a comment
There was a problem hiding this comment.
LGTM. 纯 tool 改动，新增 BREDR GATT service 用于 PTS 测试，结构和现有 service 一致。
zhongzhijie1
approved these changes
Apr 10, 2026
Contributor
zhongzhijie1
left a comment
zhongzhijie1
left a comment
There was a problem hiding this comment.
LGTM. Tools only, clean structure.
zhongzhijie1
force-pushed
the
fix/bt-gatts-bredr-service
branch
from
a971c84 to
f8b37fd
Compare
bug: v/88246 - Add new GATT service (UUID 0xFF10) declared with GATT_H_PRIMARY_SERVICE_OVER_BREDR for PTS cross-transport testing - Include TX (notify/indicate), CCCD, and RX (read/write) characteristics - Register as service id 4 (BREDR) in gatt_server tool Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>
liuX10
force-pushed
the
fix/bt-gatts-bredr-service
branch
from
f8b37fd to
d420377
Compare
huangyulong3
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add new GATT service (UUID 0xFF10) declared with GATT_H_PRIMARY_SERVICE_OVER_BREDR for PTS cross-transport testing. Includes TX, CCCD, and RX characteristics. Registered as service id 4 (BREDR).
Impact
Tools only, no production code change.
Testing
Build verified.