fix #241 - bug: Generated CHANGELOG files are missing Apache license header#244
Merged
Conversation
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #241 by ensuring package-level CHANGELOG.md files contain an Apache 2.0 license header so the Apache RAT license-header check passes during release PR CI.
Changes:
- Added an Apache 2.0 license header block (as an HTML comment) to the end of
packages/i18n/CHANGELOG.md. - Added an Apache 2.0 license header block (as an HTML comment) to the end of
packages/serverless-workflow-diagram-editor/CHANGELOG.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/i18n/CHANGELOG.md | Appends Apache 2.0 license header to satisfy RAT license scanning for the generated changelog. |
| packages/serverless-workflow-diagram-editor/CHANGELOG.md | Appends Apache 2.0 license header to satisfy RAT license scanning for the generated changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ricardozanini
approved these changes
Jul 8, 2026
1a377f3
into
open-workflow-specification:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #241
Describe the Bug
The release preparation workflow generates package
CHANGELOG.mdfiles without the Apache license header.This makes the Apache RAT check fail on release PRs.
See logs here:
Steps to reproduce
CI :: License headersjob.Expected Behavior
Generated
CHANGELOG.mdfiles should include the Apache license header and pass the Apache RAT check.Solution
I could not find a changeset option to prepend the license text in the CHANGELOG.
I tried locally adding the license before and after the package name, but that text was partially replaced or moved down with the version.
Adding the license to the bottom generated a correct changelog locally and the license was kept at the bottom as expected.
This should be ok for RAT, otherwise we can add the changelogs in
.rat-excludes