Added preview step for new share account workflow.#2511
Closed
arushi2702 wants to merge 1 commit intoopenMF:developmentfrom
Closed
Added preview step for new share account workflow.#2511arushi2702 wants to merge 1 commit intoopenMF:developmentfrom
arushi2702 wants to merge 1 commit intoopenMF:developmentfrom
Conversation
Contributor
|
@arushi2702 Please include screenshots or a screen recording. Also, run |
revanthkumarJ
suggested changes
Oct 6, 2025
Contributor
revanthkumarJ
left a comment
revanthkumarJ
left a comment
There was a problem hiding this comment.
I am not sure because i don't know xml, but i think you wrote in xml in android Main.
But this project is Kotlin multi Platform using jetpack compose. and the ui code should be placed inside commonMain .
Contributor
|
@arushi2702 are you working on these ? |
Contributor
|
@therajanmaurya This PR can be closed with reference to #2549. This has already been fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#MIFOSAC-546
Please make sure these boxes are checked before submitting your pull request - thanks!
./gradlew checkorci-prepush.shto make sure you didn't break anything(Could not run locally due to environment setup issues)