chore(build-logic): add missing dependencies to version catalog & missing build logic files

[amanna13]

Fixes - Jira-#598

chore(build-logic): complete version catalogue and build logic setup

Screen_recording_20260129_195045.mp4

• Add missing dependencies to version catalogue

• Finalize build logic configuration

• Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

• If you have multiple commits please combine them into one commit by squashing them.

[coderabbitai]

Important

Review skipped

Too many files!

This PR contains 182 files, which is 32 over the limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[biplab1]

Looks good to me. This can be merged.

[biplab1]

@amanna13 Have you checked the build on your PR branch? Is the app building fine? Please upload a screen recording in the PR description.

[amanna13]

@amanna13 Have you checked the build on your PR branch? Is the app building fine? Please upload a screen recording in the PR description.

@biplab1 Yes it's building fine, attaching a screen recording soon. The ony issue was, there was a build failure for the demoDebug variant of the client app. You can see that in this PR I have commented out the apply("org.convention.android.application.firebase") inside build-logic > convention > AndroidApplicationConventionPlugin to temporarily fix it.

The actual issue is in cmp-android/google-services.json, there’s no matching Firebase client entry for DemoDebug

[biplab1]

@amanna13 Have you checked the build on your PR branch? Is the app building fine? Please upload a screen recording in the PR description.

@biplab1 Yes it's building fine, attaching a screen recording soon. The ony issue was, there was a build failure for the demoDebug variant of the client app. You can see that in this PR I have commented out the apply("org.convention.android.application.firebase") inside build-logic > convention > AndroidApplicationConventionPlugin to temporarily fix it.

The actual issue is in cmp-android/google-services.json, there’s no matching Firebase client entry for DemoDebug

@amanna13 I think we can handle this issue in a separate ticket. Please create a ticket to update google-services.json and handle this convention plugin error which results in a package name different from that listed in the google-services.json.

[amanna13]

@biplab1 So it's commented out for now. so should i request for a merge ?!

[niyajali]

@amanna13 Have you checked the build on your PR branch? Is the app building fine? Please upload a screen recording in the PR description.

@biplab1 Yes it's building fine, attaching a screen recording soon. The ony issue was, there was a build failure for the demoDebug variant of the client app. You can see that in this PR I have commented out the apply("org.convention.android.application.firebase") inside build-logic > convention > AndroidApplicationConventionPlugin to temporarily fix it.

The actual issue is in cmp-android/google-services.json, there’s no matching Firebase client entry for DemoDebug

No, never do that instead copy the google services file from another project(https://github.com/openMF/kmp-project-template/blob/dev/cmp-android/google-services.json) and add these client info

    {
      "client_info": {
        "mobilesdk_app_id": "1:728434912738:android:53d0930e402622611a1dbb",
        "android_client_info": {
          "package_name": "com.mifos.mifosxdroid.demo.debug"
        }
      },
      "oauth_client": [
        {
          "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com",
          "client_type": 3
        }
      ],
      "api_key": [
        {
          "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70"
        }
      ],
      "services": {
        "appinvite_service": {
          "other_platform_oauth_client": [
            {
              "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com",
              "client_type": 3
            }
          ]
        }
      }
    },
    {
      "client_info": {
        "mobilesdk_app_id": "1:728434912738:android:53d0930e402622611a1dbb",
        "android_client_info": {
          "package_name": "com.mifos.mifosxdroid.debug"
        }
      },
      "oauth_client": [
        {
          "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com",
          "client_type": 3
        }
      ],
      "api_key": [
        {
          "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70"
        }
      ],
      "services": {
        "appinvite_service": {
          "other_platform_oauth_client": [
            {
              "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com",
              "client_type": 3
            }
          ]
        }
      }
    },

[niyajali]

And there are some recent changes in the template project, take a look into that and do the required changes accordingly

[amanna13]

Hey @niyajali, I tried with what you suggested with the google-services and it did work.

• I'm keeping Crashlytics true, its currently set on true for mifos-mobile but it was false in android-client

And there are some recent changes in the template project, take a look into that and do the required changes accordingly

Let's keep it what we are currently doing for now, because of this PR the core-base haven't merged yet and a lot of other PR's are waiting for that.
Dependency updates and all can be addressed once this is merged in a seperate PR, because a lot of dependencies like "room" was upgraded which introduced stricter type validation, which is currently failing I checked.

[biplab1]

@amanna13 I am curious - since you might have built using both the settings:

Does the compile and build times for debug variant build gets affected? Can you verify this:

Then those need to be updated to improve the build and compile time for debug builds

[amanna13]

Does the compile and build times for debug variant build gets affected?

@biplab1 I verified the Debug build performance by running in the same environment. With mappingFileUpload enabled, the Debug build took ~5m 30s, compared to ~3m 52s when disabled, somewhat close to 30% improvement

[biplab1]

Does the compile and build times for debug variant build gets affected?

@biplab1 I verified the Debug build performance by running in the same environment. With mappingFileUpload enabled, the Debug build took ~5m 30s, compared to ~3m 52s when disabled, somewhat close to 30% improvement

@amanna13 I am assuming you did a clean build before testing each of the settings.

Please keep the mappingFileUpload disabled for now in this project, other projects which have it enabled will also be disabled as recommended by @niyajali .

Can you also address this as pointed out by @niyajali:

And there are some recent changes in the template project, take a look into that and do the required changes accordingly

For dependencies, I think we can update them to a version where the changes in the project are minimal and manageable at the current moment.

[amanna13]

I am assuming you did a clean build before testing each of the settings.

Yes I did clean build. Okay sure I will disable that.

For dependencies, I think we can update them to a version where the changes in the project are minimal and manageable at the current moment.

Yeah, that will work, it will take me one more day to do so. I was saying previously to merge this as it is, keeping in mind the priority of this task.

[biplab1]

@amanna13 If you face any problems, feel free to start a Slack thread tagging @niyajali and me to expedite the work on this PR.

[amanna13]

@biplab1 Done with all the updations. please have a look.
(Screen recording after build updated).

[biplab1]

Looks good to me. This can be merged.