-
Notifications
You must be signed in to change notification settings - Fork 29
Remove proton/neutron Number #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: upcoming-2.0.0
Are you sure you want to change the base?
Remove proton/neutron Number #192
Conversation
We do in manual post-processing from time to time.
Yes, it does check its type. We need to remove these two lines: openPMD/openPMD-validator#39
I would like to hold this PR until we have a data converter PR for it. This way of working we will only merge changes to the standard that we can also convert to :) (The data conversion will need to implement a periodic table lookup, that's fun! :-p ) |
ax3l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor typo.
| The following additional attributes are defined in this extension. | ||
| The individual requirement is given in `scope`. | ||
|
|
||
| Note that the attributes below to not include information about the species |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to -> do
| Note that the attributes below to not include information about the species | |
| Note that the attributes below do not include information about the species |
This removes the proton/neutron number from the
ED-PICextension, since it is now possible to specify it withSpeciesType.Implements issue: Close #191
Affected Components
EXT_ED-PICLogic Changes
Expressing ions in
ED-PICcan now be done by using theSpeciesTypeextension.Writer Changes
Data writers that were writing the proton/neutron number should now use the
SpeciesTypeextension.This might require a lookup of an element name in the periodic table for the naming. Previously, one could just define two numbers without knowing how an ion/isotope is abbreviated in the periodic table.
Reader Changes
I am not aware of any reader that currently checks this attribute, but in theory data readers should now look at the
SpeciesTypeinformation.openPMD-validator: remove check inED-PICED-PIC: Remove proton/neutron Number openPMD-validator#39Data Converter
Data converters should switch to using the
SpeciesType.