Change the type of the column state to enum, step II (missing writing) #18391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraycp
force-pushed
the
write_state_and_status_II
branch
3 times, most recently
from
6be6550 to
7e9264c
Compare
These changes were missing in 1d76f7b. Luckily, they only affected the test and development environmnents.
We need to keep writing to state in specs as well. Otherwise, some of them will fail until we finally start reading only from status.
danidoni
force-pushed
the
write_state_and_status_II
branch
from
7e9264c to
c7c500e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #18173 was reverted with PR #18355, I'm going to re-introduce the changes little by little.
First of all, I introduce this commit which is a follow-up of 1d76f7b.
Missing changes to write to both
bs_requestscolumnsstateandstatus.Author: @eduardoj
NOTE: all the requests in production have correct values on status. None are nil and all those with 0 (or "new") value match the state value ("new"). This means we are writing correctly to both state and status. At least from all the parts of the code that has been run during the last weeks.