Integrate marksmith markdown editor #18435
Conversation
rubhanazeem
force-pushed
the
integrate-ms
branch
6 times, most recently
from
292a0fc to
0fafb31
Compare
rubhanazeem
force-pushed
the
integrate-ms
branch
5 times, most recently
from
65445e5 to
4c1f16e
Compare
|
Review app will appear here: http://obs-reviewlab.opensuse.org/rubhanazeem-integrate-ms |
rubhanazeem
force-pushed
the
integrate-ms
branch
from
4c1f16e to
cfba8cf
Compare
rubhanazeem
force-pushed
the
integrate-ms
branch
from
cfba8cf to
f327250
Compare
|
|
||
| # Don't compress css because we use sassc-rails compressor to compress | ||
| # css which does not support tailwind functions | ||
| Rails.application.config.assets.css_compressor = nil |
There was a problem hiding this comment.
@rubhanazeem not sure if disabling css compressing is something we can do on production. I don't have any numbers, but this probably will increase load times on every view. Have you considered exchanging sassc with https://github.com/rails/dartsass-rails/ for example?
There was a problem hiding this comment.
I looked into https://github.com/rails/cssbundling-rails but it was not working out of the box and needed a couple more modifications. I will have a look into dartsass
|
Review app will appear here: http://obs-reviewlab.opensuse.org/rubhanazeem-integrate-ms |
2 similar comments
|
Review app will appear here: http://obs-reviewlab.opensuse.org/rubhanazeem-integrate-ms |
|
Review app will appear here: http://obs-reviewlab.opensuse.org/rubhanazeem-integrate-ms |
krauselukas
removed
the
review-app
4 participants
This PR introduces a new markdown editor (marksmith)
After: