Skip to content

fix: show raw release binding resource in YAML view #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChathurangaKCD wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: show raw release binding resource in YAML view #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plugins/openchoreo-backend/src/services/transformers/release-binding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ export function transformReleaseBinding(
status: derived?.status,
statusReason: derived?.reason,
statusMessage: derived?.message,
resource: binding as unknown as Record<string, unknown>,
endpoints: (() => {
const raw = (binding.status as any)?.endpoints;
if (!Array.isArray(raw)) return undefined;
Expand Down
2 changes: 2 additions & 0 deletions plugins/openchoreo-common/src/types/bff-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,8 @@ export interface ReleaseBindingResponse {
statusMessage?: string;
endpoints?: ReleaseBindingEndpoint[];
conditions?: ReleaseBindingCondition[];
/** The raw K8s ReleaseBinding resource, used to display the full definition */
resource?: Record<string, unknown>;
}

export interface ReleaseBindingCondition {
Expand Down
2 changes: 2 additions & 0 deletions plugins/openchoreo/src/api/OpenChoreoClientApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ export interface ReleaseBinding {
status?: string;
statusReason?: string;
statusMessage?: string;
/** Raw K8s resource from the API, if available */
resource?: Record<string, unknown>;
}

/** Release bindings response */
Expand Down
4 changes: 3 additions & 1 deletion ...components/Environments/ReleaseDataRenderer/ResourceTreeView/ReleaseBindingDetailTabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,9 @@ export const ReleaseBindingDetailTabs: FC<ReleaseBindingDetailTabsProps> = ({
<>
{releaseBindingData ? (
<YamlViewer
value={YAML.stringify(releaseBindingData)}
value={YAML.stringify(
(releaseBindingData as any).resource ?? releaseBindingData,
)}
maxHeight="auto"
/>
) : (
Expand Down
Loading