fix: keep sub-second precision in audit log query window - #615
mevan-karu wants to merge 1 commit into
Conversation
The window was cut to whole seconds, so paging by the last record's time skipped or repeated records. Signed-off-by: Mevan <mevan.karu@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughAudit log query time bounds now preserve sub-second precision. Tests verify exact microsecond and millisecond values in the generated OpenSearch range filter. ChangesAudit time precision
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The audit query retains sub-second time precision with no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Purpose
The audit log query window was cut to whole seconds before it reached OpenSearch. Paging by the last record's time then skipped records (descending) or returned the same page again (ascending).
Approach
Format
startTimeandendTimewithRFC3339Nanoso the range query keeps fractions of a second.Related Issues
Part of openchoreo/openchoreo#4731
Checklist
Remarks
Needed for next-page paging in
occ auditlogs.Summary by CodeRabbit
Bug Fixes
Tests