Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions OPENCLAW.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ use an old Bun executable with headers/libraries from another engine ABI.

## Unreleased

- Release class-field identifier references when parser arenas are destroyed, preventing native string leaks during class initialization and Worker churn.

- Initialize new VM entry scratch buffers and alignment padding before entering JavaScript or native callees, preventing stale stack values from retaining otherwise unreachable objects during collection.
- Store deferred microtask entry scopes as two initialized pointers, avoiding stale optional-flag padding that can conservatively retain lexical environments and cancellation reasons.
- Verify dead-realm cleanup with the collected-realm fixture from openclaw/bun#151, adapted from oven-sh/bun#44544; thanks @robobun. Retain the qualified Linux Bun executables and hashes for three days, including failed qualification runs.
Expand Down
3 changes: 2 additions & 1 deletion Source/JavaScriptCore/parser/Nodes.h
Original file line number Diff line number Diff line change
Expand Up @@ -2401,7 +2401,8 @@ namespace JSC {
ExpressionNode* m_argument;
};

class DefineFieldNode final : public StatementNode {
class DefineFieldNode final : public StatementNode, public ParserArenaDeletable {
JSC_MAKE_PARSER_ARENA_DELETABLE_ALLOCATED(DefineFieldNode);
public:
enum class Type { Name, PrivateName, ComputedName };
DefineFieldNode(const JSTokenLocation&, const Identifier&, ExpressionNode*, Type);
Expand Down
1 change: 1 addition & 0 deletions Tools/TestWebKitAPI/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ if (ENABLE_JAVASCRIPTCORE)
Tests/JavaScriptCore/DisallowVMEntry.cpp
Tests/JavaScriptCore/InspectorConsoleMessage.cpp
Tests/JavaScriptCore/MarkedVector.cpp
Tests/JavaScriptCore/ParserArena.cpp
Tests/JavaScriptCore/PropertySlot.cpp
Tests/JavaScriptCore/RegularExpression.cpp
Tests/JavaScriptCore/StrongBlock.cpp
Expand Down
58 changes: 58 additions & 0 deletions Tools/TestWebKitAPI/Tests/JavaScriptCore/ParserArena.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
/*
* Copyright (C) 2026 Peter Steinberger All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
* THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
* BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
* THE POSSIBILITY OF SUCH DAMAGE.
*/

#include "config.h"

#include <JavaScriptCore/IdentifierInlines.h>
#include <JavaScriptCore/InitializeThreading.h>
#include <JavaScriptCore/JSLock.h>
#include <JavaScriptCore/JSCJSValueInlines.h>
#include <JavaScriptCore/NodeConstructors.h>
#include <JavaScriptCore/VM.h>

namespace TestWebKitAPI {

TEST(JavaScriptCore_ParserArena, DefineFieldReleasesIdentifier)
{
WTF::initializeMainThread();
JSC::initialize();
RefPtr<JSC::VM> vm = JSC::VM::create(JSC::HeapType::Small);
JSC::JSLockHolder locker(vm.get());
auto identifier = JSC::Identifier::fromString(*vm, "parserArenaFieldIdentifier"_s);
auto initialRefCount = identifier.impl()->refCount();

for (auto type : { JSC::DefineFieldNode::Type::Name, JSC::DefineFieldNode::Type::PrivateName, JSC::DefineFieldNode::Type::ComputedName }) {
{
JSC::ParserArena arena;
new (arena) JSC::DefineFieldNode(JSC::JSTokenLocation { }, identifier, nullptr, type);
EXPECT_EQ(initialRefCount + 1, identifier.impl()->refCount());
}
EXPECT_EQ(initialRefCount, identifier.impl()->refCount());
}
identifier = { };
vm = nullptr;
}

} // namespace TestWebKitAPI