-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Bug/login account activation msg #37642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Bug/login account activation msg #37642
Conversation
…l rendering default courses
…n by stringifing to match with what backend handles (json)
…_bar.js for refreshing contents when clear selected orgs
that was left over from testing the feature implementation.
|
Thanks for the pull request, @kemalatgithub! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Bug: Fix missing email in account activation message on login page
Description
Issue: #37406
After a new user registers but does not confirm their email, logs out, and logs in again, the login page shows the following incomplete message:
"We couldn't sign you in.
In order to sign in, you need to activate your account.
We just sent an activation link to . If you do not receive an email, check your spam folders or contact …"
There should be a <user_email> after to ......
Current Status:
Issue reproduced locally.
Verified that after a new user registers but does not confirm their email, logs out, and logs back in, the activation message is displayed without the user’s email.

Next Steps:
Implement fix to include the user’s email in the activation message.
Add template/view updates as needed.
Add a unit test to verify the email is shown correctly.