refactor: Move upload/delete transcript into video_config service #37657
Conversation
kdmccormick
changed the title
kdmccormick
force-pushed
the
kdmccormick/upload-delete-transcript
branch
3 times, most recently
from
b27c671 to
097c430
Compare
kdmccormick
requested review from
farhan,
irtazaakram and
salman2013
as code owners
This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction: openedx#36282
kdmccormick
force-pushed
the
kdmccormick/upload-delete-transcript
branch
from
696e7df to
a738d26
Compare
farhan
added
the
create-sandbox
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
|
Transcripts are not uploading in the content library 
|
| Can raise: | ||
| * UnicodeDecodeError | ||
| * TranscriptsGenerationException |
There was a problem hiding this comment.
Should we throw platform specific exceptions, for example TranscriptsGenerationException here? 🤔
Even if we throw them we can't catch the specific exceptions within the external XBlock.
So if we can only catch the general exception in the external XBlock. Shouldn't we only throw general exceptions?
| if is_library: | ||
| # Save transcript as static asset in Learning Core if is a library component | ||
| filename = f'transcript-{new_language_code}.srt' | ||
| add_library_block_static_asset_file(video_block.usage_key, f"static/{filename}", content) |
| UsageKey, | ||
| ) | ||
| from opaque_keys.edx.locator import LibraryLocatorV2 | ||
| from xblocks_contrib.video import VideoBlock |
There was a problem hiding this comment.
Shouldn't we import it from the xmodule.
I am also having import VideoBlock in this PR, will be great if we could skip its annotation until we are done with extraction work.
| ), | ||
| status=201, | ||
| ) | ||
| except (TranscriptsGenerationException, UnicodeDecodeError): |
There was a problem hiding this comment.
In the extracted XBlock, we are not going to capture these special exceptions.
Further discussed here
3 participants
Description
This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction:
#36282
Testing instructions
Go to studio, and in a course, add a transcript, and delete it.
Do the same in a v2 library.