-
Notifications
You must be signed in to change notification settings - Fork 168
feat: add games xblock editor #2656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2656 +/- ##
==========================================
- Coverage 94.83% 94.70% -0.14%
==========================================
Files 1234 1235 +1
Lines 27764 27808 +44
Branches 6094 6104 +10
==========================================
+ Hits 26331 26335 +4
- Misses 1375 1404 +29
- Partials 58 69 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
With this Commit, games xblock editor is in place now! - copy code from https://github.com/openedx-unsupported/frontend-lib-content-components/pull/371/files to authoring MFE - It includes refactoring in .scss files, useIntl, replacing deprecated dependencies, fixing reducers, fixed cancel/close editor button, fix dragging the cards, edit some styles and also removed duplicate styling etc.
a86c137 to
9610f07
Compare
|
Can you please provide some context here? What is the "games" XBlock? I had seen some references to the games editor in the code before, but I thought it was just a sample/template editor that could be used for making new editors, not an actual XBlock. |
openedx proposal link for this. |
|
Ah, thanks. I hadn't seen that. Can you please make sure this PR is following our best practices checklist before you mark it as not a draft?
|
kdmccormick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned on the product proposal, we cannot be hard coding new block editors into the platform.
With this PR, games xblock editor is in place now!
Changes:
Screen.Recording.2025-11-12.at.6.44.32.PM.mov