Skip to content

Conversation

@Faraz32123
Copy link
Contributor

With this PR, games xblock editor is in place now!

Changes:

Screen.Recording.2025-11-12.at.6.44.32.PM.mov

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 10.63830% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.70%. Comparing base (54cfbeb) to head (9610f07).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/editors/data/redux/game/reducers.js 2.50% 28 Missing and 11 partials ⚠️
src/editors/data/redux/game/selectors.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2656      +/-   ##
==========================================
- Coverage   94.83%   94.70%   -0.14%     
==========================================
  Files        1234     1235       +1     
  Lines       27764    27808      +44     
  Branches     6094     6104      +10     
==========================================
+ Hits        26331    26335       +4     
- Misses       1375     1404      +29     
- Partials       58       69      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

With this Commit, games xblock editor is in place now!
- copy code from https://github.com/openedx-unsupported/frontend-lib-content-components/pull/371/files to authoring MFE
  - It includes refactoring in .scss files, useIntl, replacing deprecated dependencies, fixing reducers, fixed cancel/close editor button, fix dragging the cards, edit some styles and also removed duplicate styling etc.
@bradenmacdonald
Copy link
Contributor

Can you please provide some context here? What is the "games" XBlock? I had seen some references to the games editor in the code before, but I thought it was just a sample/template editor that could be used for making new editors, not an actual XBlock.

@Faraz32123
Copy link
Contributor Author

Can you please provide some context here? What is the "games" XBlock? I had seen some references to the games editor in the code before, but I thought it was just a sample/template editor that could be used for making new editors, not an actual XBlock.

openedx proposal link for this.

@bradenmacdonald
Copy link
Contributor

Ah, thanks. I hadn't seen that.

Can you please make sure this PR is following our best practices checklist before you mark it as not a draft?

  • Any new files are using TypeScript (.ts, .tsx) - index.jsx should be index.tsx
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx and editor tests should use editorRender from @src/editors/editorTestRender
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
    Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
    • it looks like you are adding the new editor's state to the Redux store. I guess this is because you are copying existing code, so it's OK in that case but I'd prefer that we do not use redux at all for this new editor.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned on the product proposal, we cannot be hard coding new block editors into the platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants