feat(chart): make ClusterIssuer configurable and ingress-class aware - #193
feat(chart): make ClusterIssuer configurable and ingress-class aware#193MoisesGSalas wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @MoisesGSalas! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
7247acc to
e8242d7
Compare
Add a `clusterIssuer` values section so the `harmony-letsencrypt-global` ClusterIssuer can be toggled and its ACME HTTP01 ingress class can be customized. - Fix the Traefik provider key casing from `kubernetesIngressNginx` to `kubernetesIngressNGINX` so it validates against the Traefik sub-chart schema. - Use a better default value for `clusterDomain`. The current value of `*` is not a valid hostname and will cause an error when rendering templates.
e8242d7 to
7f68405
Compare
|
Hi @gabor-boros, this is a small PR with a few fixes. I want to make a release before completely removing ingress-nginx (#194 WIP). |
Add a
clusterIssuervalues section so theharmony-letsencrypt-globalClusterIssuer can be toggled and its ACME HTTP01 ingress class can be customized.kubernetesIngressNginxtokubernetesIngressNGINXso it validates against the Traefik sub-chart schema.