fix: course_detail title is being set by block.display_name already#38160
fix: course_detail title is being set by block.display_name already#38160marslanabdulrauf wants to merge 1 commit intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @marslanabdulrauf! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
…ride from ABOUT_ATTRIBUTES
70a36c7 to
b5d2202
Compare
Related Ticket (MIT Internal)
https://github.com/mitodl/hq/issues/10256
Description
This pull request makes a minor change to the
openedx/core/djangoapps/models/course_details.pyfile by removing thetitlefield from theABOUT_ATTRIBUTESlist.As its already being set a couple of lines above
There are cases where the title field is empty (not None but "") and in that case we override valid title from

block.display_namewith this empty value causing empty title inCourseInfoSidebarTesting instructions
{studio}/authoring/course/{course_key}CourseInfoSidebar