Modernize python tooling - #685
Conversation
|
Thanks for the pull request, @salman2013! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #685 +/- ##
===========================================
- Coverage 97.93% 33.38% -64.55%
===========================================
Files 84 36 -48
Lines 8043 3034 -5009
Branches 0 362 +362
===========================================
- Hits 7877 1013 -6864
- Misses 166 2021 +1855
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Faraz32123
left a comment
There was a problem hiding this comment.
Thanks for the PR. Once CI is green, I'll again take a look at the PR.
| python-version: | ||
| - '3.12' | ||
| toxenv: [django52, quality] | ||
| toxenv: [django42, django52, quality] |
There was a problem hiding this comment.
django42 testing was already dropped. Let's only support django5.2.
|
👋 Reviewed this against the same checklist we've been applying across the modernization effort. One shared issue, one non-blocking note:
Minor/non-blocking: |
10e707e to
9e15933
Compare
7696adf to
6c30241
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6c30241 to
9a92bec
Compare
|
@Faraz32123 You can review the PR, thanks. |
Modernizes the Python tooling for xblock-lti-consumer in three phases, aligning with the Open edX org standard established in openedx/sample-plugin.
Ticket: openedx/public-engineering#511
Parent ticket: openedx/public-engineering#506
Changes generated by Claude Sonnet 4.6 using the modernize-python-tooling skill, reviewed by human.