Skip to content

rename length2 to lengthSquared #7680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+6 −7
Open

rename length2 to lengthSquared #7680

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85feacc
rename length2 to lengthSquared
artificiel Sep 28, 2023
915446b
Merge branch 'openframeworks:master' into squared
artificiel Sep 28, 2023
06aa693
Merge branch 'openframeworks:master' into squared
artificiel Oct 6, 2023
0d7c777
Merge branch 'openframeworks:master' into squared
artificiel May 25, 2024
ac8e845
Merge branch 'openframeworks:master' into squared
artificiel Oct 31, 2024
a6444a1
Merge branch 'openframeworks:master' into squared
artificiel Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions libs/openFrameworks/math/ofQuaternion.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,9 @@ class ofQuaternion {
inline float length() const;

/// \brief Length of the quaternion = vec . vec
inline float length2() const;

inline float lengthSquared() const;
[[deprecated("use lengthSquare")]] inline float length2() const { return lengthSquared(); };

/// \brief Conjugate
inline ofQuaternion conj() const;

Expand Down Expand Up @@ -459,13 +460,11 @@ float ofQuaternion::length() const {
return std::sqrt(_v.x*_v.x + _v.y*_v.y + _v.z*_v.z + _v.w*_v.w);
}


//----------------------------------------
float ofQuaternion::length2() const {
return _v.x*_v.x + _v.y*_v.y + _v.z*_v.z + _v.w*_v.w;
float ofQuaternion::lengthSquared() const {
return _v.x*_v.x + _v.y*_v.y + _v.z*_v.z + _v.w*_v.w;
}


//----------------------------------------
ofQuaternion ofQuaternion::conj() const {
return ofQuaternion(-_v.x, -_v.y, -_v.z, _v.w);
Expand All @@ -474,7 +473,7 @@ ofQuaternion ofQuaternion::conj() const {

//----------------------------------------
const ofQuaternion ofQuaternion::inverse() const {
return conj() / length2();
return conj() / lengthSquared();
}


Expand Down