Stop getting gold from conquering inactive players 🔧

[FloPinguin]

Description:

Maybe for v29.

In the 5M starting gold modifier games you can conquer a inactive player (spawned but didn't do anything) and get their 5M gold.
Huge unfair advantage.
I think that even without the starting gold modifier you should not get the gold of inactive players because its unfair.

I identify inactive players (spawned but didn't do anything) by checking the attack stats.
I added a translation for the displayMessage "Conquered {name}, received {gold} gold". Why was that not translated?
I added a new message "Conquered {name} (Inactive player, received no gold)".

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

FloPinguin

[coderabbitai]

Walkthrough

Conquest now skips transferring gold when a conquered Human has no recorded attacks sent; active defenders still yield gold and record goldWar. Display events differ: conquered_no_gold for skipped transfers, received_gold_from_conquest when gold is awarded. Tests updated to reflect activation requirements.

Changes

Cohort / File(s)	Summary
Localization resources/lang/en.json	Added events_display.received_gold_from_conquest and events_display.conquered_no_gold translation entries.
Conquest Logic src/core/game/GameImpl.ts	Import ATTACK_INDEX_SENT; check defender's ATTACK_INDEX_SENT for Human defenders. If zero, skip gold transfer and goldWar stat, emit conquered_no_gold; otherwise compute/transfer gold, emit received_gold_from_conquest with numeric and rendered gold, and record goldWar.
Tests tests/AttackStats.test.ts	Activate defenders where needed before attacks (schedule AttackExecution) and add a test asserting no war gold is awarded when eliminating an inactive defender.

Sequence Diagram

sequenceDiagram
    participant Conquest as Conquest Handler
    participant Stats as Player Stats Store
    participant Event as Event System
    participant Locale as Localization

    Conquest->>Stats: Query defender ATTACK_INDEX_SENT
    alt Defender active (attacksSent > 0)
        Stats-->>Conquest: attacksSent > 0
        Conquest->>Conquest: Compute gold amount
        Conquest->>Stats: conqueror.addGold(gold) / conquered.removeGold(gold)
        Conquest->>Stats: Record goldWar stat
        Conquest->>Event: Create `received_gold_from_conquest` with {name, gold, rendered}
        Event->>Locale: Request localized message with params
        Locale-->>Event: Return formatted message
    else Defender inactive (attacksSent == 0)
        Stats-->>Conquest: attacksSent == 0
        Conquest->>Event: Create `conquered_no_gold` with {name}
        Event->>Locale: Request localized message with params
        Locale-->>Event: Return formatted message
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

Conquest checks who fought and who slept,
Coins for the brave, none for those unkept,
Two messages mark the ending night,
One for treasure, one for quiet flight,
Tests wake defenders to set things right ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: preventing gold rewards from conquering inactive players, which aligns with the core purpose of the pull request.
Description check	✅ Passed	The description is detailed and directly related to the changeset, explaining the motivation, implementation approach, UI/text changes, and confirming tests and translations were added.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[evanpelle]

thanks!