fix; improvement proposal for the leaderboard buttons#3107
fix; improvement proposal for the leaderboard buttons#3107martinIvovIv wants to merge 4 commits intoopenfrontio:mainfrom
Conversation
WalkthroughThe left sidebar gained visual enhancements through additional styling classes applied to wrapper divs. The changes add padding, background color with hover effects, borders, rounded corners, and color transitions. No functional or logical modifications were made. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@src/client/graphics/layers/GameLeftSidebar.ts`:
- Around line 131-132: The clickable div that invokes toggleTeamLeaderboard in
GameLeftSidebar.ts needs keyboard accessibility added: give that div
role="button", a tabindex="0", and wire its keyboard handler to the same keydown
handler used elsewhere (handleKeyDown or the existing handler bound for other
clickable sidebars) so Enter/Space trigger this.toggleTeamLeaderboard; update
the element attributes and ensure the keydown method references
toggleTeamLeaderboard so keyboard users can activate it.
- Around line 115-118: The div acting as a button in the GameLeftSidebar
template should be made keyboard-accessible: add role="button" and tabindex="0"
attributes to the element and attach an `@keydown` handler that listens for Enter
and Space keys and invokes the existing toggleLeaderboard() method; ensure the
handler prevents default for Space to avoid page scroll and normalizes checks
for event.key === "Enter" or event.key === " " / event.code === "Space".
|
I'm thinking about how the buttons move, they should always be on the top, feels odd to "move" the button? like sometimes its above everything, other times its below the team you're on |
|
@ryanbarlow97 The first screenshot is from a free for all game, the second screenshot with "Your team" text is in a teams game, if this is what you mean. Could you elaborate more ? Also the text with "Your team: Purple" appears on teams games but dissapears after the game starts. If anything, I can make another PR and swap the position of the text and the buttons in multiplayer games. |
Description:
Changes the leaderboard buttons to look more like other buttons per suggestion by @FloPinguin
Please complete the following:
Screenshots:
Before change:

After change:

After change hover:

Mobile:

##Discord username: martoi
Signed-off-by: MartinIvovIv https://github.com/martinIvovIv