Added source for join context

[ryanbarlow97]

Description:

Added source for join context

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

w.o.n

[coderabbitai]

Walkthrough

The PR adds a source field to the JoinLobbyEvent payload across four files to identify the origin of lobby join requests. The field captures whether the join originated from host, public, private, matchmaking, or single-player paths, with no control-flow changes.

Changes

Cohort / File(s)	Summary
JoinLobbyEvent Source Tracking src/client/HostLobbyModal.ts, src/client/JoinLobbyModal.ts, src/client/Matchmaking.ts, src/client/SinglePlayerModal.ts	Added source field to JoinLobbyEvent detail object to identify the origin of lobby join requests ("host", "public", "private", "matchmaking", "singleplayer").

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🎮 Four pathways converge, each with a name,
Source now tracks where the joiners came,
From host to matchmaker, solo to crew,
The lobby remembers exactly who's who! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: adding a source field to track the join context across multiple join paths (host, public, private, matchmaking, singleplayer).
Description check	✅ Passed	The description is related to the changeset, confirming completion of required tasks including screenshots, text localization, tests, and thorough testing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR adds a source field to all JoinLobbyEvent dispatches to track the context from which a lobby was joined. The source field was already defined in the JoinLobbyEvent interface as an optional field, and this change ensures it's populated in all cases.

Changes:

• Added source tracking to distinguish between different join contexts: "singleplayer", "matchmaking", "public", "private", and "host"
• Updated all five locations that dispatch join-lobby events to include the appropriate source value
• The source field is used in Main.ts to conditionally update the URL based on join context (non-public lobbies update URL immediately)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/client/SinglePlayerModal.ts	Added source: "singleplayer" to the JoinLobbyEvent dispatch
src/client/Matchmaking.ts	Added source: "matchmaking" to the JoinLobbyEvent dispatch
src/client/JoinLobbyModal.ts	Added source: "public" for public lobby joins and source: "private" for private lobby and archived game joins
src/client/HostLobbyModal.ts	Added source: "host" to the JoinLobbyEvent dispatch

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.