Skip to content

Cv32a65x-act4 - #3265

Open
arshiarifat-10x wants to merge 34 commits into
openhwgroup:masterfrom
arshiarifat-10x:cv32a65x-act4
Open

Cv32a65x-act4#3265
arshiarifat-10x wants to merge 34 commits into
openhwgroup:masterfrom
arshiarifat-10x:cv32a65x-act4

Conversation

@arshiarifat-10x

@arshiarifat-10x arshiarifat-10x commented Apr 7, 2026

Copy link
Copy Markdown

This PR integrates the RISC-V Architectural Compatibility Test (ACT) v4.0 framework for the CV32A65x configuration of the CVA6 core, enabling architecture compliance test generation and execution within the CVA6 simulation environment.

@cainria cainria left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arshiarifat-10x

Please add a description to this pull request so that we can understand the rationale of these changes and discuss them.

Comment thread .gitmodules Outdated
@JeanRochCoulon

Copy link
Copy Markdown
Contributor

Hello @arshiarifat-10x
Thanks for your interest in cva6.
It would be useful to integrate your tests, or a part of them (depend on the duration), to the Github Actions CI. The scope is to prevent regression. Of course, to run on Github Actions, they should be executed with Verilator (possible?)

@arshiarifat-10x

arshiarifat-10x commented Apr 17, 2026

Copy link
Copy Markdown
Author

@JeanRochCoulon
I have integrated all the tests into the GitHub Actions CI using Verilator.
The current full regression takes approximately ~25 minutes to complete in CI. This is within a workable range, but if needed, we can later review the suite and discuss trimming specific tests to optimize runtime while preserving regression coverage.

@JeanRochCoulon

Copy link
Copy Markdown
Contributor

As specified in CONTRIBUTING.md, can you give me the right to rebase your branch.

@arshiarifat-10x

Copy link
Copy Markdown
Author

@JeanRochCoulon
Yes, I’ve enabled maintainer access for rebasing.

@arshiarifat-10x
arshiarifat-10x requested a review from cainria April 20, 2026 14:14

@cainria cainria left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add a README to document how to use this new testing framework?

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .gitmodules Outdated
Comment thread verif/regress/wrapper-cv32a65x-act.sh Outdated
Comment thread verif/regress/wrapper-cv32a65x-act.sh Outdated
Comment thread verif/regress/wrapper-cv32a65x-act.sh Outdated
Comment thread verif/sim/Makefile
Comment thread verif/sim/Makefile Outdated
Comment thread verif/sim/Makefile Outdated
Comment thread verif/sim/Makefile
arshiarifat-10x and others added 12 commits April 21, 2026 11:18
Co-authored-by: Côme <come.allart@inria.fr>
Co-authored-by: Côme <come.allart@inria.fr>
Co-authored-by: Côme <come.allart@inria.fr>
Co-authored-by: Côme <come.allart@inria.fr>
Co-authored-by: Côme <come.allart@inria.fr>
Co-authored-by: Côme <come.allart@inria.fr>
Co-authored-by: Côme <come.allart@inria.fr>
Co-authored-by: Côme <come.allart@inria.fr>
@ASintzoff

Copy link
Copy Markdown
Contributor

Currently, test suites are cloned on demand when the corresponding tests are executed. For instance, there is already the script verif/regress/install-riscv-arch-test.sh cloning riscv-arch-test into verif/tests/riscv-arch-test.

Could you consider to reuse this script?

@MikeOpenHWGroup

Copy link
Copy Markdown
Member

The ACT4 certification test suite does not work that way @ASintzoff. ACT4 is not a library of tests, it is a test-generator. The process of generating these tests is rather long and complex so for other CORE-V cores we are employing the following strategy:

  1. Use the ACT4 tools to generate tests. This would be done manually for on-going development and/or integration of ACT4/UDB/Sail updates. It is anticipated that this would not happen often.
  2. Generate the test once and then commit them to a regression directory. These would be run often.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi there!

This pull request seems inactive. Need more help or have updates? Feel free to let us know. If there are no updates within the next few days, we'll go ahead and close this PR. 😊

@github-actions github-actions Bot added the Status:Stale Issue or PR is stale and hasn't received any updates. label Jun 21, 2026
@MikeOpenHWGroup

Copy link
Copy Markdown
Member

Hi @ASintzoff, we should discuss how to move forward on this.

@JeanRochCoulon JeanRochCoulon removed the Status:Stale Issue or PR is stale and hasn't received any updates. label Jun 21, 2026
@JeanRochCoulon

Copy link
Copy Markdown
Contributor

Hello @arshiarifat-10x Why core-v-verif is updated ? This PR should not modify the core-v-verif hash

@JeanRochCoulon

Copy link
Copy Markdown
Contributor

@AlexChenIC The Verible repo cannot be fetched. Do you have an idea howto fix it ?

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

❌ failed run, report available here.

@JeanRochCoulon

Copy link
Copy Markdown
Contributor

Hello @arshiarifat-10x we are ready to merge. But the CI is red due to an installation issue.

@cainria

cainria commented Jul 9, 2026

Copy link
Copy Markdown
Member

I add it here for visibility: as mentioned in #3265 (comment) this PR adds a requirement to uv which is not fulfilled by the GitHub runner, hence the job failures.

@JeanRochCoulon

JeanRochCoulon commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@AlexChenIC What about adding the job in your Github action CI ? This will reduce engineering work to directly push it into the final targeted CI. It would be more efficient. Do you share this view ?

@AlexChenIC

Copy link
Copy Markdown
Contributor

@AlexChenIC What about adding the job in your Github action CI ? This will reduce engineering work to directly push it into the final targeted CI. It would be more efficient. Do you share this view ?

Hi @JeanRochCoulon, yes, I share this view. I think that ACT4 would be a good fit for the Tier CI as a dedicated Tier 2 job for CV32A65X. I should be able to take on this integration. I’ll start by evaluating the workflow. Based on my initial assessment, the integration looks feasible

@cainria

cainria commented Aug 5, 2026

Copy link
Copy Markdown
Member

Hi! Any news about this PR ?

@arshiarifat-10x

Copy link
Copy Markdown
Author

@cainria README was pending i added that. I hope the CI issue is resolved.

@arshiarifat-10x

Copy link
Copy Markdown
Author

Since @AlexChenIC mentioned taking on the Tier-2 ACT4 CI integration, should I wait for that, or should I add the uv installation support on my side? @JeanRochCoulon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants