Draft: Add Svadu, Svpbmt, and Svinval support - #3384
Draft
sjo99-kr wants to merge 17 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR will be discussed on next CVA6 community meeting (15th July).
This draft PR adds initial support for several RISC-V virtual-memory-related extensions in CVA6:
I am opening this as a draft PR to make the implementation visible early and to get feedback from the CVA6 community on the overall architecture, interfaces, and review direction.
Sorry for one BIG PR rather than separate PRs, since those extensions are all for virtual address-related modifications
New Module for Svadu
store_unit.svand shared AMO port wtihamo_buffer.sv.You can find detailed descriptions of this in google doc file.
(doc: https://docs.google.com/document/d/1ypJdJz2CnGH1iI8uIijN8Pk9YOaYb5urEnP2yZa9vrY/edit?usp=sharing)
Verification
UseSharedTLB,SvaduEn,SvpbmtEn,SvinvalEn.You can find detailed descriptions of coverage tests and regression tests, the following results in google doc file.
(doc : https://docs.google.com/document/d/1ypJdJz2CnGH1iI8uIijN8Pk9YOaYb5urEnP2yZa9vrY/edit?usp=sharing)
Related Issue
cva6.pybeyondcv32a60xandcv32a65x, which both already havespike.yamlfile. So I just added specific optionspike_extensionincva6.pyfile. I mainly used this for verification, and I don't think this modification needs to be reviewed for merge, it's just for verification.vaddr/ASIDselector #3307 raises the bug of sfence.vma, and I found that the issue was caused by a bit-width mismatch, fixed it in this PR, and confirmed that the related test no longer fails.store_itiming on the PMP side and confirmed that the related test no longer fails.cva6_shared_tlb.svin my PR is based on the PR Improved TLB flushing logic for Supervisor mode #3312, because Svinval is directly related to TLB flush/invalidation behavior. I adapted the shared-TLB flush flow from that PR for the Svinval implementation.--
There could be more issues related my PR and tests, but I'm happy to hang on here, and modify all concerns to be merged. So, feel free to tell me concerns, and really thank you guys for reviewing :)
Review_guidance_cva6.pdf