pmp: require execute permission for HLVX accesses - #3413
Open
Maanvi212006 wants to merge 4 commits into
Open
Conversation
Signed-off-by: Maanvi212006 <maanvichetwani21@gmail.com>
Signed-off-by: Maanvi212006 <maanvichetwani21@gmail.com>
Signed-off-by: Maanvi212006 <maanvichetwani21@gmail.com>
Author
|
Hii @JeanRochCoulon , the Verible / format (pull_request_target) is unrelated to my PR. The PR is ready for review. Thanks!
|
Member
|
Indeed a PR is open to fix Verible #3403 |
Member
Author
|
Hi @JeanRochCoulon a gentle ping! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why is this PR needed for the project?
HLVX accesses must require both read and execute permissions from PMP, as specified by the RISC-V Privileged Specification. Previously, HLVX accesses were checked as normal read accesses, allowing execution through read-only PMP regions.
This change forwards the HLVX flag to the PMP data interface and performs the permission check with both
ACCESS_READandACCESS_EXEC.Issue
fixes #3400
Are there limitations with the current state of this contribution?
This change only updates the PMP permission check for HLVX accesses. No additional verification tests are included in this PR.