fix(decoder): preserve SFENCE.VMA rd legality in RVH VS-mode path - #3470
Open
jf-cc727 wants to merge 1 commit into
Open
fix(decoder): preserve SFENCE.VMA rd legality in RVH VS-mode path#3470jf-cc727 wants to merge 1 commit into
jf-cc727 wants to merge 1 commit into
Conversation
Member
|
It seems you are not using the same email for all your contributions, hence the ECA check failure. |
jf-cc727
force-pushed
the
fix/cv-5-vs-sfence-rd
branch
from
August 12, 2026 11:58
b18f133 to
f424338
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a VS-mode
SFENCE.VMAlegality bug under RVH.When
CVA6Cfg.RVH && v_i, the decoder correctly clears the temporary virtual-illegal condition for the legal VS-mode case. However, that path can also overwrite an earlier structural-illegal result, such asrd != x0, and incorrectly make the instruction legal.This change keeps
SFENCE.VMAillegal whenrd != x0while still preserving the intended RVH / VS-mode behavior for the legal case.Validated with the test reproducer (
tohost = 0).Related issue: #3459