Skip to content

Conversation

@Apurv428
Copy link
Collaborator

@Apurv428 Apurv428 commented May 8, 2024

Fixed issue #110 which was addressed in the PR.
I have addressed the changes which were requested on the PR

Signed-off-by: Apurv Sonawane <[email protected]>
@pleia2
Copy link
Contributor

pleia2 commented May 10, 2024

Since @aashish-khatri wrote the code you're basing this PR on, you will need to include his work in your workflow so proper credit is assigned to the author. This is very important 😄

So instead of just copying it into your PR, you will want to:

  1. Checkout his code from added automation for z/OS open tools #124 (which includes his commits)
  2. Rebase the code with what is in the master branch (there's a lot of extra changes in your file diffs)
  3. Apply your improvements
  4. Push that back up to this PR, making sure all the commits are included, which give an audit trail to include Aashish's work

Let me know if you need any help!

@Apurv428
Copy link
Collaborator Author

Since @aashish-khatri wrote the code you're basing this PR on, you will need to include his work in your workflow so proper credit is assigned to the author. This is very important 😄

So instead of just copying it into your PR, you will want to:

  1. Checkout his code from added automation for z/OS open tools #124 (which includes his commits)
  2. Rebase the code with what is in the master branch (there's a lot of extra changes in your file diffs)
  3. Apply your improvements
  4. Push that back up to this PR, making sure all the commits are included, which give an audit trail to include Aashish's work

Let me know if you need any help!

I was unaware that this can be done.
I will make the changes.
Thanks!

@Apurv428
Copy link
Collaborator Author

Opened #195 with the required changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants