(feat) O3-4060 : Enable or Disable tutorials for onboarding module #22
Conversation
jayasanka-sack
left a comment
jayasanka-sack
left a comment
There was a problem hiding this comment.
The "tutorials" menu item should be hidden if the config is set to false.
Vijaykv5
force-pushed
the
feat/O3-4060
branch
from
a6c001c to
23dadc4
Compare
|
Thanks @Vijaykv5. Could you please send me a screenshot? Also, shall we rename the config to |
src/tutorial/tutorial.tsx
Outdated
| <div onClick={handleOpenModal}>{t('tutorials', 'Tutorials')}</div> | ||
| </> | ||
| ); | ||
| return <>{showTutorial && <div onClick={handleOpenModal}>{t('tutorials', 'Tutorials')}</div>}</>; |
There was a problem hiding this comment.
We should return null here to completely avoid rendering the component. We need to do the same for the root component so that the joyride component won't get rendered too.
updated.mov |
|
@jayasanka-sack How can we modify the test, since the tutorials are disabled by default, this results in failing tests(missing the tutorials section) |
|
@gracepotma should we enable tutorials by default? The plan is to include this config to bundle this package with the release, and implementors can enable/disable or add their tutorials. |
2 participants
Requirements
For changes to apps
If applicable
Summary
This PR add a config to the onboarding module to enable/disable the tutorials.
It is
disabledby defaultScreenshots
enable.disable.tutorials.mov
Related Issue
O3-4060
Other
cc : @jayasanka-sack