Skip to content

SCI scenarios first attempt#61

Closed
mzecc wants to merge 1 commit into
mainfrom
sci_attempt
Closed

SCI scenarios first attempt#61
mzecc wants to merge 1 commit into
mainfrom
sci_attempt

Conversation

@mzecc

@mzecc mzecc commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Description

Draft PR to give an idea of the work done for the SCI integration.

All scenarios currently report only at the global level. For now, I'm mocking the regional part by creating a regional sector that is a copy of the global one.

Another option would be to skip the preprocessing step and prepare the input data directly in the required format.

What do you think?

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.72%. Comparing base (217be88) to head (8544055).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   81.72%   81.72%           
=======================================
  Files          32       32           
  Lines        1335     1335           
  Branches      125      125           
=======================================
  Hits         1091     1091           
  Misses        209      209           
  Partials       35       35           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mzecc mzecc marked this pull request as draft June 24, 2026 20:48
@mzecc mzecc requested a review from znicholls June 24, 2026 20:49

@znicholls znicholls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first attempt. Let's see what comes out of this meeting later, then we can figure out how to pull this into gcages. I really want to avoid too much noise/action in gcages now if we can, because it's not clear to me what the benefit of that noise would be (in other words, why merge this, when we haven't even agreed what we're actually trying to do).

@znicholls znicholls Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the work, but please let's get rid of this. Everything should just go in the existing CMIP7 ScenarioMIP notebook. Most of the stuff here is just hacks to make the SCI data fit, and I really want to avoid them ending up in gcages (maybe we keep some helpers, but even then I'd hesitate). We can point to climate-processor instead once that's public.

@mzecc mzecc Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thank you very much for the feedback Zeb! Closing this now

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pull this out and just replace the ScenarioMIP infilling db (this file is the same data plus extraso there's no need to have both)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's strip this down to a couple of key examples rather than committing a 90MB excel file

@mzecc mzecc closed this Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants