SCI scenarios first attempt#61
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 81.72% 81.72%
=======================================
Files 32 32
Lines 1335 1335
Branches 125 125
=======================================
Hits 1091 1091
Misses 209 209
Partials 35 35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
znicholls
left a comment
There was a problem hiding this comment.
Good first attempt. Let's see what comes out of this meeting later, then we can figure out how to pull this into gcages. I really want to avoid too much noise/action in gcages now if we can, because it's not clear to me what the benefit of that noise would be (in other words, why merge this, when we haven't even agreed what we're actually trying to do).
There was a problem hiding this comment.
I appreciate the work, but please let's get rid of this. Everything should just go in the existing CMIP7 ScenarioMIP notebook. Most of the stuff here is just hacks to make the SCI data fit, and I really want to avoid them ending up in gcages (maybe we keep some helpers, but even then I'd hesitate). We can point to climate-processor instead once that's public.
There was a problem hiding this comment.
Ok thank you very much for the feedback Zeb! Closing this now
There was a problem hiding this comment.
Let's pull this out and just replace the ScenarioMIP infilling db (this file is the same data plus extraso there's no need to have both)
There was a problem hiding this comment.
Let's strip this down to a couple of key examples rather than committing a 90MB excel file
Description
Draft PR to give an idea of the work done for the SCI integration.
All scenarios currently report only at the global level. For now, I'm mocking the regional part by creating a regional sector that is a copy of the global one.
Another option would be to skip the preprocessing step and prepare the input data directly in the required format.
What do you think?
Checklist
Please confirm that this pull request has done the following:
changelog/