Skip to content

Preserve ONVIF reference parameters in subscription requests - #1027

Merged
matteius merged 5 commits into
mainfrom
ai-findings-autofix33/src-video-onvif_detection.c
Nov 20, 2026
Merged

matteius merged 5 commits into
mainfrom
ai-findings-autofix33/src-video-onvif_detection.c

Conversation

@matteius

@matteius matteius commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Parse the complete PullPoint endpoint reference, including ReferenceParameters and inherited namespace declarations. Store those headers with the subscription and include them in subsequent PullMessages, Renew, and Unsubscribe SOAP requests. Reject oversized endpoint reference data instead of truncating it. Also simplify malformed Motion tag scanning. The ONVIF transport suite passes, including a new reference-parameter envelope test.

matteius and others added 2 commits November 19, 2026 23:06
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.00000% with 30 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/video/onvif_detection.c 70.00% 30 Missing ⚠️

📢 Thoughts on this report? Let us know!

github-actions Bot and others added 2 commits November 20, 2026 04:14
@matteius matteius changed the title Potential fixes for 2 code quality findings Preserve ONVIF reference parameters in subscription requests Nov 20, 2026
@matteius
matteius marked this pull request as ready for review November 20, 2026 04:16
Generated by tools/rust-transpile/generate.py for fcfbe95.
@matteius
matteius merged commit 226cada into main Nov 20, 2026
4 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant