Skip to content

Fix ONVIF event classification, malformed XML, and LPR buffering - #993

Merged
matteius merged 6 commits into
mainfrom
ai-findings-autofix/src-video-onvif_detection.c
Nov 19, 2026
Merged

matteius merged 6 commits into
mainfrom
ai-findings-autofix/src-video-onvif_detection.c

Conversation

@matteius

@matteius matteius commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Retains three safe AI finding fixes: motorbike classification, malformed XML fallback, and larger LPR batches. The LPR array is heap allocated and only allocated for likely LPR responses to avoid a large per-thread stack frame. Adds regression tests. Two proposed fixes were removed: releasing the global subscription registry mutex during network operations would race slot reuse and shutdown; the relative URL change called undefined helpers and changed the legacy endpoint behavior without validation.

matteius and others added 6 commits November 18, 2026 23:32
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@matteius matteius changed the title Potential fixes for 5 code quality findings Fix ONVIF event classification, malformed XML, and LPR buffering Nov 19, 2026
@matteius
matteius marked this pull request as ready for review November 19, 2026 04:38
@matteius
matteius merged commit 0cb6234 into main Nov 19, 2026
2 of 12 checks passed
@matteius
matteius deleted the ai-findings-autofix/src-video-onvif_detection.c branch November 19, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant