OCPBUGS-77895: Allow for override of agent vcpu and memory#1862
Conversation
bfournie
force-pushed
the
allow-agent-overides
branch
from
40d6034 to
cd31964
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
bfournie
force-pushed
the
allow-agent-overides
branch
from
cd31964 to
0e08c59
Compare
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
bfournie
force-pushed
the
allow-agent-overides
branch
4 times, most recently
from
29ce364 to
567b3d4
Compare
common.sh
Outdated
| export ARM_WORKER_MEMORY=${ARM_WORKER_MEMORY:-${WORKER_MEMORY}} | ||
| export ARM_WORKER_DISK=${ARM_WORKER_DISK:-${WORKER_DISK}} | ||
| export ARM_WORKER_VCPU=${ARM_WORKER_VCPU:-${WORKER_VCPU}} | ||
| if [[ -z ${AGENT_E2E_TEST_SCENARIO:-} ]]; then |
There was a problem hiding this comment.
It doesn't look the right approach to modify the very base initial config. We've got already a section to specify agent stuff conditionally, so eventually we should insert the changes there rather than duplicating. Wondering also why we need so many resources for the conformance tests, but we can discuss it separately
bfournie
force-pushed
the
allow-agent-overides
branch
from
567b3d4 to
6d54ebc
Compare
|
/test e2e-agent-sno-ipv6 |
|
Perhaps this patch could help: 955a31f |
bfournie
force-pushed
the
allow-agent-overides
branch
from
6d54ebc to
a59be20
Compare
Yes, that's similar to my original approach in this PR. I like this approach because it allows iterative testing in openshift/release. Updated. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
The CI conformance tests need more resources than currently configured for installations. Allow these settings to be overridden. This requires a corresponding change in openshift/release to use higher limits.
bfournie
force-pushed
the
allow-agent-overides
branch
from
a59be20 to
5f02f5b
Compare
|
|
||
| export AGENT_TEST_CASES=${AGENT_TEST_CASES:-} | ||
|
|
||
| export MASTER_MEMORY=${MASTER_MEMORY:-16384} |
There was a problem hiding this comment.
Would be nice to to explain that these are the fallback values of they haven't been set by the code above.
|
/retest-required |
|
@bfournie: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-metal-ipi-serial-ipv4-1of2 |
openshift-merge-bot
bot
merged commit 9a5162c
into
openshift-metal3:master
4 participants
The CI conformance tests need more resources than currently configured for installations. Allow these settings to be overridden. This requires a corresponding change in openshift/release to use higher limits.