-
Notifications
You must be signed in to change notification settings - Fork 49
OCPCLOUD-3102: Merge https://github.com/kubernetes-sigs/cluster-api-provider-aws:v2.10.0 (175074f) into main #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPCLOUD-3102: Merge https://github.com/kubernetes-sigs/cluster-api-provider-aws:v2.10.0 (175074f) into main #582
Conversation
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.3.0 to 2.4.0. - [Release notes](https://github.com/go-viper/mapstructure/releases) - [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md) - [Commits](go-viper/mapstructure@v2.3.0...v2.4.0) --- updated-dependencies: - dependency-name: github.com/go-viper/mapstructure/v2 dependency-version: 2.4.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the dependencies group in /hack/tools with 7 updates: | Package | From | To | | --- | --- | --- | | [github.com/a8m/envsubst](https://github.com/a8m/envsubst) | `1.4.2` | `1.4.3` | | [github.com/mikefarah/yq/v4](https://github.com/mikefarah/yq) | `4.44.6` | `4.47.1` | | [github.com/spf13/pflag](https://github.com/spf13/pflag) | `1.0.6` | `1.0.7` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.32.3` | `0.32.8` | | [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) | `0.17.3` | `0.18.0` | | [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind) | `0.26.0` | `0.29.0` | | [sigs.k8s.io/kustomize/kustomize/v5](https://github.com/kubernetes-sigs/kustomize) | `5.5.0` | `5.7.1` | Updates `github.com/a8m/envsubst` from 1.4.2 to 1.4.3 - [Release notes](https://github.com/a8m/envsubst/releases) - [Commits](a8m/envsubst@v1.4.2...v1.4.3) Updates `github.com/mikefarah/yq/v4` from 4.44.6 to 4.47.1 - [Release notes](https://github.com/mikefarah/yq/releases) - [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt) - [Commits](mikefarah/yq@v4.44.6...v4.47.1) Updates `github.com/spf13/pflag` from 1.0.6 to 1.0.7 - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.6...v1.0.7) Updates `k8s.io/apimachinery` from 0.32.3 to 0.32.8 - [Commits](kubernetes/apimachinery@v0.32.3...v0.32.8) Updates `sigs.k8s.io/controller-tools` from 0.17.3 to 0.18.0 - [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/main/envtest-releases.yaml) - [Commits](kubernetes-sigs/controller-tools@v0.17.3...v0.18.0) Updates `sigs.k8s.io/kind` from 0.26.0 to 0.29.0 - [Release notes](https://github.com/kubernetes-sigs/kind/releases) - [Commits](kubernetes-sigs/kind@v0.26.0...v0.29.0) Updates `sigs.k8s.io/kustomize/kustomize/v5` from 5.5.0 to 5.7.1 - [Release notes](https://github.com/kubernetes-sigs/kustomize/releases) - [Commits](kubernetes-sigs/kustomize@kustomize/v5.5.0...kustomize/v5.7.1) --- updated-dependencies: - dependency-name: github.com/a8m/envsubst dependency-version: 1.4.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: github.com/mikefarah/yq/v4 dependency-version: 4.47.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: github.com/spf13/pflag dependency-version: 1.0.7 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: k8s.io/apimachinery dependency-version: 0.32.8 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: sigs.k8s.io/controller-tools dependency-version: 0.18.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: sigs.k8s.io/kind dependency-version: 0.29.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: sigs.k8s.io/kustomize/kustomize/v5 dependency-version: 5.7.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
…king until previous one is finished (which may have led to failing nodes due to outdated join token)
Bumps [github.com/ulikunitz/xz](https://github.com/ulikunitz/xz) from 0.5.12 to 0.5.14. - [Commits](ulikunitz/xz@v0.5.12...v0.5.14) --- updated-dependencies: - dependency-name: github.com/ulikunitz/xz dependency-version: 0.5.14 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
🐛 Add missing IAM permission `ec2:RevokeSecurityGroupEgress` for `emptyRoutesDefaultVPCSecurityGroup` option
…ot/go_modules/hack/tools/dependencies-dfc3b1ee10 🌱 Bump the dependencies group in /hack/tools with 7 updates
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.3.0 to 2.4.0. - [Release notes](https://github.com/go-viper/mapstructure/releases) - [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md) - [Commits](go-viper/mapstructure@v2.3.0...v2.4.0) --- updated-dependencies: - dependency-name: github.com/go-viper/mapstructure/v2 dependency-version: 2.4.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…ot/go_modules/hack/tools/github.com/ulikunitz/xz-0.5.14 🌱 Bump github.com/ulikunitz/xz from 0.5.12 to 0.5.14 in /hack/tools
…ot/go_modules/hack/tools/github.com/go-viper/mapstructure/v2-2.4.0 🌱 Bump github.com/go-viper/mapstructure/v2 from 2.3.0 to 2.4.0 in /hack/tools
🌱 WIP: Devbox updates
✨ Create only one nat gateway per AZ
…ot/go_modules/github.com/go-viper/mapstructure/v2-2.4.0 🌱 Bump github.com/go-viper/mapstructure/v2 from 2.3.0 to 2.4.0
…to-metadata 🌱 Add kind: Metadata to metadata manifests
…rsion-optional-for-unencrypted 🌱 Fix(ignition): Default version only if not storageType UnencryptedUserData
…r-return 🐛 Return early if Cluster is paused
Bumps the dependencies group in /hack/tools with 4 updates: [github.com/spf13/pflag](https://github.com/spf13/pflag), [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery), [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) and [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind). Updates `github.com/spf13/pflag` from 1.0.7 to 1.0.10 - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.7...v1.0.10) Updates `k8s.io/apimachinery` from 0.33.0 to 0.33.4 - [Commits](kubernetes/apimachinery@v0.33.0...v0.33.4) Updates `sigs.k8s.io/controller-tools` from 0.18.0 to 0.19.0 - [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/main/envtest-releases.yaml) - [Commits](kubernetes-sigs/controller-tools@v0.18.0...v0.19.0) Updates `sigs.k8s.io/kind` from 0.29.0 to 0.30.0 - [Release notes](https://github.com/kubernetes-sigs/kind/releases) - [Commits](kubernetes-sigs/kind@v0.29.0...v0.30.0) --- updated-dependencies: - dependency-name: github.com/spf13/pflag dependency-version: 1.0.10 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: k8s.io/apimachinery dependency-version: 0.33.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: sigs.k8s.io/controller-tools dependency-version: 0.19.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: sigs.k8s.io/kind dependency-version: 0.30.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
|
I spun up a cluster with this PR to debug and attempt to fix the second issue (interference from a previous test case). When the issue occurred, I didn't see any configuration from other test cases in the AWSMachineTemplate, so I suspect this might also be affected by the first issue (no AWSMachine). So I'd like to wait for the first issue to be fixed and then rerun the tests to see if the second issue persists. |
|
Attempting a fix here: openshift/cluster-capi-operator#420 |
|
@cloud-team-rebase-bot[bot]: This pull request references OCPCLOUD-3102 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-capi-techpreview regression-clusterinfra-aws-ipi-techpreview-capi |
|
/test e2e-aws-capi-techpreview |
|
/test regression-clusterinfra-aws-ipi-techpreview-capi |
|
/test e2e-aws-capi-techpreview |
|
/test e2e-aws-capi-techpreview regression-clusterinfra-aws-ipi-techpreview-capi |
1 similar comment
|
/test e2e-aws-capi-techpreview regression-clusterinfra-aws-ipi-techpreview-capi |
|
For job ci/prow/e2e-aws-capi-techpreview failed, it reports "Process did not finish before 2h0m0s timeout", so I raise a pr to add time openshift/cluster-capi-operator#422 For job ci/prow/regression-clusterinfra-aws-ipi-techpreview-capi failed, the case failed because it was affected by previous cases because they use the same awsmachinetemplate name, I updated pr openshift/cluster-api-actuator-pkg#454 and tested in my local works We can retest this when those PRs merged. |
|
Timeout issues also occurred in openshift/cluster-api-actuator-pkg#454 now. I'm not sure what's causing this, but these timeout issues may not be random. @chrischdi has investigated this https://redhat-internal.slack.com/archives/C05KZA3NVU6/p1765220669974759?thread_ts=1765191426.215559&cid=C05KZA3NVU6 |
|
/test e2e-aws-capi-techpreview |
|
/testwith openshift/cluster-api-provider-aws/main/e2e-aws-capi-techpreview openshift/cluster-capi-operator#423 |
|
/testwith openshift/cluster-api-provider-aws/main/regression-clusterinfra-aws-ipi-techpreview-capi openshift/cluster-capi-operator#423 |
|
/testwith openshift/cluster-api-provider-aws/main/e2e-aws-capi-techpreview openshift/cluster-capi-operator#423 |
|
/test e2e-aws-capi-techpreview |
|
/test regression-clusterinfra-aws-ipi-techpreview-capi |
|
@cloud-team-rebase-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by regression tests passing, CI being green and and a detailed analysis of controller logs in https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-api-provider-aws/582/pull-ci-openshift-cluster-api-provider-aws-main-e2e-aws-capi-techpreview/1998413475088437248 |
|
@damdo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/unhold |
10ceef5
into
openshift:main
No description provided.