Skip to content

Conversation

@mpatlasov
Copy link
Contributor

@mpatlasov mpatlasov commented Dec 22, 2025

The first commit makes copy/pasta of sniff-test.md from Jonathan's PR (kudos to @dobsonj for the implementation!). The second commit fixes a typo found by this command.

The typo found by Claude: `/sniff-test pkg/generator/asset_generator.go`
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 22, 2025
@openshift-ci-robot
Copy link

@mpatlasov: This pull request explicitly references no jira issue.

Details

In response to this:

The first commit makes copy/pasta of sniff-test.md from Jonathan's PR (kudos to @dobsonj for the implementation). The second commit fixes a typo found by this command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jsafrane and tsmetana December 22, 2025 07:17
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2025
@mpatlasov
Copy link
Contributor Author

/retest-required

1 similar comment
@Phaow
Copy link
Contributor

Phaow commented Dec 24, 2025

/retest-required

@dobsonj
Copy link
Member

dobsonj commented Jan 5, 2026

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dobsonj
Copy link
Member

dobsonj commented Jan 5, 2026

/override ci/prow/okd-scos-images
/verified by @dobsonj

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 5, 2026
@openshift-ci-robot
Copy link

@dobsonj: This PR has been marked as verified by @dobsonj.

Details

In response to this:

/override ci/prow/okd-scos-images
/verified by @dobsonj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2026

@dobsonj: Overrode contexts on behalf of dobsonj: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images
/verified by @dobsonj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 34fad4d and 2 for PR HEAD 5725543 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2026

@mpatlasov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3b21c8b into openshift:main Jan 5, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants