Adding support for payload multiple-stream.#180
Adding support for payload multiple-stream.#180ybettan wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
CI is failing with @sdodson What version of OKD introduce the |
Dockerfile
Outdated
| io.openshift.release.operator=true \ | ||
| version="0.1" | ||
| version="0.1" \ | ||
| rhel-stream=${RHEL_STREAM} \ |
There was a problem hiding this comment.
Are you proposing using this label instead of the streamclass label? Would be nice to be consistent here.
There was a problem hiding this comment.
I was just following the existing labels of DTK (some of them don't have any prefix) but it is better to set it to io.openshift.os.streamclass=${RHEL_STREAM}.
Fixing...
|
/retest |
|
Did you test how this works in a PR to release repo? The Also, OKD needs to work. |
ybettan
force-pushed
the
dual-stream
branch
3 times, most recently
from
8192889 to
135c837
Compare
| @@ -0,0 +1,78 @@ | |||
| FROM registry.ci.openshift.org/ocp/4.22:rhel-coreos-10 | |||
There was a problem hiding this comment.
@joepvd
There is no registry.ci.openshift.org/ocp/4.22:base-rhel10 in the release repo.
Should I use registry.ci.openshift.org/ocp/4.22:rhel-coreos-10 or should we add a new registry.ci.openshift.org/ocp/4.22:base-rhel10 image in the CI registry?
ybettan
force-pushed
the
dual-stream
branch
2 times, most recently
from
c236343 to
231919e
Compare
The multiple-stream effort will contain multiple images considered as `machine-os` in the payload as well as multiple `driver-toolkit` images. This commit is adding some labels to the container such as the `rhel-stream` and `kernel-version`. In addition it adds a reference to the `rhel-coreos-10` image in order to specify to the payload that DTK depends on the `rhel-coreos-10` image. The Dockerfile has been split into 2 Dockerfile, one for each rhel release. In the future, it may extend to 3 Dockerfile including rhel for nvidia. Signed-off-by: Yoni Bettan <yonibettan@gmail.com>
|
@ybettan: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I have now because I split the Dockerfile. This is the chicken and egg problem though. CI fill fail here because the is no |
4 participants
The multiple-stream effort will contain multiple images considered as
machine-osin the payload as well as multipledriver-toolkitimages.This commit is adding some labels to the container such as the
rhel-streamandkernel-version.In addition it adds a reference to the
rhel-coreos-10image in order to specify to the payload that DTK depends on therhel-coreos-10image./assign @jlebon
/cc @dustymabe @sdodson @travier @joepvd