Skip to content

Conversation

@djoshy
Copy link
Contributor

@djoshy djoshy commented Jul 9, 2025

This EP update describes how the MCO could implement boot image updates to ControlPlaneMachineSets.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 9, 2025

@djoshy: This pull request references MCO-1007 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This EP update describes how the MCO could implement boot image updates to ControlPlaneMachineSets.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from mandre and mike-nguyen July 9, 2025 16:48
@djoshy
Copy link
Contributor Author

djoshy commented Jul 11, 2025

@openshift-ci openshift-ci bot closed this Jul 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2025

@djoshy: Closed this PR.

Details

In response to this:

/close

ref: https://issues.redhat.com/browse/MCO-1007?focusedId=27585523&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-27585523

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JoelSpeed
Copy link
Contributor

@djoshy Now that we have explored this a bit further, I think we should get the EP updated and continue the discussion here?

@djoshy
Copy link
Contributor Author

djoshy commented Sep 19, 2025

@djoshy Now that we have explored this a bit further, I think we should get the EP updated and continue the discussion here?

Will do!

/reopen

@openshift-ci openshift-ci bot reopened this Sep 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2025

@djoshy: Reopened this PR.

Details

In response to this:

@djoshy Now that we have explored this a bit further, I think we should get the EP updated and continue the discussion here?

Will do!

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2025

@djoshy: This pull request references MCO-1007 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This EP update describes how the MCO could implement boot image updates to ControlPlaneMachineSets.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy djoshy changed the title MCO-1007: add CPMS boot image update support MCO-1895: add CPMS boot image update support Oct 1, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 1, 2025

@djoshy: This pull request references MCO-1895 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This EP update describes how the MCO could implement boot image updates to ControlPlaneMachineSets.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy djoshy force-pushed the add-CPMS-boot-image branch from 22b2616 to 3ac9231 Compare October 2, 2025 19:55
@djoshy
Copy link
Contributor Author

djoshy commented Oct 2, 2025

Updated to reflect our discussions, should be good for a look when you have a second @JoelSpeed. I pulled in the API changes from openshift/api#2396 as well so it matches our latest iteration.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as well, thanks for the update!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

@djoshy: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c70af00 into openshift:master Oct 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants