OCPBUGS-61678: fix(kas): Disable PSA enforcement in 4.21

[kevinrizza]

Disable PSA enforcement in 4.21

Related to openshift/api#2623

See #6830 for reference

[openshift-ci-robot]

@kevinrizza: This pull request references Jira Issue OCPBUGS-61678, which is invalid:

• expected Jira Issue OCPBUGS-61678 to depend on a bug targeting a version in 4.22.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Disable PSA enforcement in 4.21

Related to openshift/api#2623

See #6830 for reference

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sjenning]

/retest-required

[sjenning]

Hypershift uses Conventional Commit styling in the commit messages, enforced by verify.
https://github.com/openshift/hypershift/blob/main/.gitlint

Linting commits from 382e87ce76b32797717eae673e650d009ae29dff to d8f69e23a455d11adcb81464051f95675c97f14a (CI: PR targeting 382e87ce76b32797717eae673e650d009ae29dff)
1399
2: B4 Second line is not empty: "as PSA enforcement is not being enabled"

Trying to figure out what is happening with unit.

[sjenning]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sjenning]

/test unit
/override ci/prow/e2e-aks

[openshift-ci]

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aks

Details

In response to this:

/test unit
/override ci/prow/e2e-aks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sjenning]

This is actually set here now, dependent on the feature flag

hypershift/control-plane-operator/controllers/hostedcontrolplane/v2/kas/config.go

Lines 159 to 163 in 382e87c

	if !slices.Contains(p.FeatureGates, "OpenShiftPodSecurityAdmission=true") {
	config.AdmissionConfig.PluginConfig["PodSecurity"].Configuration.Object.(*podsecurityadmissionv1.PodSecurityConfiguration).Defaults.Enforce = "privileged"
	} else {
	config.AdmissionConfig.PluginConfig["PodSecurity"].Configuration.Object.(*podsecurityadmissionv1.PodSecurityConfiguration).Defaults.Enforce = "restricted"
	}

If you want to disable it, you have to remove it from the Default FeatureSet here https://github.com/openshift/api/blob/bfa868a224015e94456731c1b5b0c849f901b417/features/features.go#L71-L77

[rtheis]

/cc @rtheis

[kaleemsiddiqu]

/retest

[openshift-ci]

@kevinrizza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aks	cee1b3a	link	true	/test e2e-aks
ci/prow/verify	cee1b3a	link	true	/test verify
ci/prow/okd-scos-images	cee1b3a	link	true	/test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.