-
Notifications
You must be signed in to change notification settings - Fork 488
GCP-447: inject token-minter as native sidecar init container #7965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we pass this to karpenter-operator/controllers/karpenter/karpenter_controller.go as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
karpenter_controller.go creates the karpenter component (v2/karpenter/component.go) which doesn't call InjectTokenMinterContainer, so setting NativeSidecarContainersEnabled in its ControlPlaneContext would have no effect.
The karpenter-operator component (v2/karpenteroperator/component.go) does use InjectTokenMinterContainer, but it's reconciled by the HCP controller which already sets the flag.
Happy to add it proactively if you prefer. I just want to confirm since it appears to be a no-op currently.