SPLAT-2172: AWS dedicate host support #10079

vr4manta · 2025-11-13T18:42:28Z

Changes

Bumped openshift/api
Added logic to allow HostPlacement of dedicated hosts

Dependencies

Notes

MAO and CAO changes are needed for it to fully work. For now, this PR is adding the ability to generate the needed outputs for bootstrapping.

openshift-ci-robot · 2025-11-13T18:42:32Z

@vr4manta: This pull request references SPLAT-2172 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

SPLAT-2172

Changes

Bumped openshift/api

Added logic to allow HostPlacement of dedicated hosts

Dependencies

SPLAT-2206: Added AWS dedicated host support api#2484

SPLAT-2167: Added dedicated hosts support for AWS machine-api-operator#1419

SPLAT-2167: Added dedicated host support for AWS cluster-capi-operator#374

SPLAT-2540: Added test support for AWS dedicated hosts cluster-api-actuator-pkg#446

Notes

MAO and CAO changes are needed for it to fully work. For now, this PR is adding the ability to generate the needed outputs for bootstrapping.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-11-13T18:43:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rna-afk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tthvo · 2025-11-14T00:35:26Z

/cc

tthvo · 2025-11-18T02:10:05Z

/retest-required

tthvo

Cool feature 👍 🚀

I have quite some comments 😅 Sorry if I review a little too soon...

pkg/types/aws/validation/machinepool.go

tthvo · 2025-11-18T05:56:02Z

pkg/types/aws/validation/machinepool.go

+		switch *p.HostPlacement.Affinity {
+		case aws.HostAffinityAnyAvailable:
+			if p.HostPlacement.DedicatedHost != nil {
+				allErrs = append(allErrs, field.Required(fldPath.Child("dedicatedHost"), "dedicatedHost is required when 'affinity' is set to DedicatedHost, and forbidden otherwise"))


Did you mean hostPlacement.dedicatedHost is forbidden if affinity is AnyAvailable?

allErrs = append(allErrs, field.Forbidden(fldPath.Child("dedicatedHost"), "dedicatedHost must not be set when affinity is AnyAvailable"))

@tthvo So this was an interesting one. In openshift/api and openshift/machine-api-operator, it was suggested to error this way for this scenario. I was doing this to keep it consistent.

https://github.com/openshift/api/blob/0598ae66682433c49adc29b1ff14a201487f3afe/machine/v1beta1/types_awsprovider.go#L406

openshift/machine-api-operator@f669914#diff-30c686f7a9dbd2aa917e5e410401d720a2a4bf4a11163495f5610c8f4b98edaeR917

Now that said, I am happy to make your suggestion if you prefer installer say it this way. Just let me know.

pkg/types/aws/validation/machinepool.go

pkg/types/aws/validation/machinepool_test.go

pkg/asset/installconfig/aws/validation.go

tthvo · 2025-11-18T10:21:46Z

pkg/asset/installconfig/aws/validation.go

+			if err != nil {
+				allErrs = append(allErrs, field.InternalError(placementPath.Child("dedicatedHost"), err))
+			} else {
+				// Check the returned configured hosts to see if the dedicated hosts defined in install-config exists.


💡 ❓ I got 2 questions here:

Do the zones of dedicated hosts need to match machinepool zone field if defined?

installer/pkg/types/aws/machinepool.go

Lines 5 to 9 in 7c9b71a

type MachinePool struct {

// Zones is list of availability zones that can be used.

//

// +optional

Zones []string `json:"zones,omitempty"`

Do the user-input zones for dedicated hosts need to match with the actual zones returned from AWS?

// If user specified a zone, validate it matches AWS if host.Zone != "" && host.Zone != hostDetails.Zone { allErrs = append(allErrs, field.Invalid( fldPath.Child("hostPlacement", "dedicatedHost").Index(i).Child("zone"), host.Zone, fmt.Sprintf("specified zone %s does not match actual host zone %s", host.Zone, hostDetails.Zone))) }

pkg/asset/machines/worker.go

pkg/asset/machines/aws/awsmachines.go

tthvo · 2025-11-18T10:46:11Z

pkg/asset/machines/aws/machinesets.go

+func isAuthoritativeClusterAPIRequired(provider *machineapi.AWSMachineProviderConfig) bool {
+	if provider.HostPlacement != nil && *provider.HostPlacement.Affinity != machineapi.HostAffinityAnyAvailable {
+		return true
+	}
+	return false
+}


🤔 Are we OK to determine the authoritative API by checking if certain install-config fields are being used (i.e. in this case, machine host placement)?

That is, IIUC, the authoritative API should be controlled by feature gate set (maybe) or the up-coming CORS-4005?

/cc @patrickdillon

Yeah in CORS-4005 or the related stories we will be adding support for generating CAPI compute manifests and adding an install config field to allow users to toggle between MAPI & CAPI.

The cloud team advised us to NOT use the term AuthoritativeAPI for that because that is strictly a MAPI thing (for converting to CAPI).

I haven't been able to review this PR closely, but IIUC you are relying on AuthortativeAPI to convert MAPI manifests to CAPI and we don't want to do that, we want to have first-class capi compute manifests.

vr4manta · 2025-11-18T18:45:04Z

/hold
Need to rebase and add validation logic to make sure defined dedicated hosts are in zones based on the machinepool config.

openshift-ci · 2025-11-19T22:22:26Z

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/aws-private	`31347ee`	link	false	`/test aws-private`
ci/prow/e2e-aws-ovn-heterogeneous	`31347ee`	link	false	`/test e2e-aws-ovn-heterogeneous`
ci/prow/e2e-aws-default-config	`31347ee`	link	false	`/test e2e-aws-default-config`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2025

openshift-ci bot requested review from mtulio and patrickdillon November 13, 2025 18:43

openshift-ci bot requested a review from tthvo November 14, 2025 00:35

vr4manta force-pushed the SPLAT-2172 branch 3 times, most recently from 24500b6 to 342ab2d Compare November 17, 2025 17:44

tthvo reviewed Nov 18, 2025

View reviewed changes

vr4manta force-pushed the SPLAT-2172 branch from 342ab2d to f624e2f Compare November 18, 2025 18:51

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2025

vr4manta force-pushed the SPLAT-2172 branch 3 times, most recently from 87b49a0 to d7292af Compare November 19, 2025 15:02

Add IPI installation on AWS dedicated hosts

31347ee

vr4manta force-pushed the SPLAT-2172 branch from d7292af to 31347ee Compare November 19, 2025 17:51

	type MachinePool struct {
	// Zones is list of availability zones that can be used.
	//
	// +optional
	Zones []string `json:"zones,omitempty"`

SPLAT-2172: AWS dedicate host support #10079

Are you sure you want to change the base?

SPLAT-2172: AWS dedicate host support #10079

Conversation

vr4manta commented Nov 13, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Dependencies

Notes

Uh oh!

openshift-ci-robot commented Nov 13, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Dependencies

Notes

Uh oh!

openshift-ci bot commented Nov 13, 2025

Uh oh!

tthvo commented Nov 14, 2025

Uh oh!

tthvo commented Nov 18, 2025

Uh oh!

tthvo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tthvo Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

vr4manta Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tthvo Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tthvo Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

patrickdillon Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

vr4manta commented Nov 18, 2025

Uh oh!

openshift-ci bot commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vr4manta commented Nov 13, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 13, 2025 •

edited by openshift-ci bot

Loading