OCPBUGS-17667: Validate vCenter datacenters in failure domain topology

[jcpowermac]

Add validation to ensure failureDomain.Topology.Datacenter is listed in the associated vCenter.Datacenters array. Previously, users could specify a datacenter that wasn't in the vCenter's datacenters list, which would only fail at runtime during installation.

This change provides early validation with a clear error message indicating which vCenter's datacenters list is missing the entry.

Assisted by Claude.

🤖 Generated with Claude Code

[openshift-ci-robot]

@jcpowermac: This pull request references Jira Issue OCPBUGS-17667, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add validation to ensure failureDomain.Topology.Datacenter is listed in the associated vCenter.Datacenters array. Previously, users could specify a datacenter that wasn't in the vCenter's datacenters list, which would only fail at runtime during installation.

This change provides early validation with a clear error message indicating which vCenter's datacenters list is missing the entry.

Assisted by Claude.

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dav1x for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/types/vsphere/validation/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jcpowermac]

/jira refresh

[openshift-ci-robot]

@jcpowermac: This pull request references Jira Issue OCPBUGS-17667, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @WenXinWei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tthvo]

/lgtm

[tthvo]

/retest

[openshift-ci]

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	64e5e4e	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-techpreview	64e5e4e	link	false	/test e2e-vsphere-ovn-techpreview
ci/prow/e2e-vsphere-ovn-zones	64e5e4e	link	false	/test e2e-vsphere-ovn-zones
ci/prow/e2e-vsphere-ovn-hybrid-env	64e5e4e	link	false	/test e2e-vsphere-ovn-hybrid-env
ci/prow/e2e-vsphere-ovn	64e5e4e	link	true	/test e2e-vsphere-ovn
ci/prow/e2e-vsphere-multi-vcenter-ovn	64e5e4e	link	false	/test e2e-vsphere-multi-vcenter-ovn
ci/prow/e2e-vsphere-ovn-disk-setup-techpreview	64e5e4e	link	false	/test e2e-vsphere-ovn-disk-setup-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.