-
Notifications
You must be signed in to change notification settings - Fork 1.5k
OSASINFRA-3965: Update cluster-api-provider-openstack to v0.13.0 #10090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSASINFRA-3965: Update cluster-api-provider-openstack to v0.13.0 #10090
Conversation
|
Currently WIP as I'm seeing dependency issues. |
83843be to
1c9cf1f
Compare
|
/retitle OSASINFRA-3965: Update cluster-api-provider-openstack to v0.13.0 |
|
@stephenfin: This pull request references OSASINFRA-3965 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1650820 to
373c5c4
Compare
373c5c4 to
2488953
Compare
2488953 to
cea409c
Compare
|
/assign @mandre I believe this is good to go, and I was able to stand up a cluster successfully using a release image built with this PR. |
This is split out from CAPO starting with CAPO v0.12.0. Start deploying it manually in preparation for a CAPO bump. Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
Achieved by bumping the library itself:
pushd cluster-api/providers/openstack
go get -u sigs.k8s.io/cluster-api-provider-openstack@latest
go mod tidy
go mod vendor
popd
Followed by the assets:
pushd <path-to-upstream-capo-repo>
git checkout v0.13.0
make release-manifests
popd
cp <path-to-upstream-capo-repo>/out/infrastructure-components.yaml \
data/data/cluster-api/openstack-infrastructure-components.yaml
This has the side effect of bumping golang to 1.24.
Signed-off-by: Stephen Finucane <[email protected]>
cea409c to
112e876
Compare
|
Rebased onto |
|
/test openstack-manifests Slow mirrors? |
|
/retest |
1 similar comment
|
/retest |
|
@stephenfin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I think this is good to go. The last runs of /assign @mandre |
|
/verified by multiple CI jobs |
|
@stephenfin: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/e2e-openstack-ovn |
|
@stephenfin: Overrode contexts on behalf of stephenfin: ci/prow/e2e-openstack-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
mandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
I doubt I'm able to approve this patch, but let's try anyway. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7d0584e
into
openshift:main
Achieved by bumping the library itself:
Followed by the assets:
This has the side effect of bumping golang to 1.24 for this module.