OCPBUGS-65512: Removing resources on destroy by other filters

[barbacbd]

** Firewall rules seem to be an issue on destroy with load balancers. The load balancers may have resource names created with a name such as a9123-xxxxx-xxxx. These resources are only discovered once, and it is possible when a failure occurs that the destroy process will skip finding these resources later. Now the firewall rules will be found using the name OR target tags. When the name does not appear to be part of the cluster (including the cluster id), then the target tags should be searched to determine if they are part of the cluster. This should handle the load balancer resources too.

[openshift-ci-robot]

@barbacbd: This pull request references Jira Issue OCPBUGS-65512, which is invalid:

• expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.19.z" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

** Firewall rules seem to be an issue on destroy with load balancers. The load balancers may have resource names created with a name such as a9123-xxxxx-xxxx. These resources are only discovered once, and it is possible when a failure occurs that the destroy process will skip finding these resources later. Now the firewall rules will be found using the name OR target tags. When the name does not appear to be part of the cluster (including the cluster id), then the target tags should be searched to determine if they are part of the cluster. This should handle the load balancer resources too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/destroy/gcp/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[barbacbd]

/jira refresh

[openshift-ci-robot]

@barbacbd: This pull request references Jira Issue OCPBUGS-65512, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianli-wei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jianli-wei]

/verified by jiwei

[openshift-ci-robot]

@jianli-wei: This PR has been marked as verified by jiwei.

In response to this:

/verified by jiwei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[barbacbd]

/retest

[openshift-ci]

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-vsphere-ovn	725fe4a	link	false	/test okd-scos-e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tthvo]

/lgtm