Update registry.redhat.io/openshift4/ose-must-gather-rhel9 Docker digest to 7658453 release-1.4#2076
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe ChangesMust-gather image pin update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@must-gather/Dockerfile`:
- Around line 1-2: The Dockerfile lacks a USER directive, which means the
container will run as root by default. Add a USER directive with a non-root user
(such as `nobody`, `1000`, or another dedicated application user) before the
final CMD statement at the end of the Dockerfile to ensure the container runs
with appropriate security constraints and least privilege access.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 123816f1-0350-44b3-bc18-52a593155921
📒 Files selected for processing (1)
must-gather/Dockerfile
| FROM registry.redhat.io/openshift4/ose-must-gather-rhel9@sha256:765845321663c5fa696ea049cbbd4a4f1328bae2de268b5273408fd284ca7169 as builder | ||
|
|
There was a problem hiding this comment.
🔒 Security & Privacy | 🔴 Critical
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check for USER directive in the Dockerfile
# Check for any USER directives in the file
rg -n '^USER\s+' must-gather/Dockerfile
# Also show the full Dockerfile structure to see all stages
cat -n must-gather/DockerfileRepository: openshift/kueue-operator
Length of output: 2015
Add USER directive with non-root user to final stage.
The Dockerfile is missing a USER directive. Containers default to running as root when no USER is specified. As per path instructions, add a USER command with a non-root user (e.g., nobody, 1000, or a dedicated application user) before the final CMD statement at line 21.
🧰 Tools
🪛 Trivy (0.69.3)
[error] 1-1: Image user should not be 'root'
Specify at least 1 USER command in Dockerfile with non-root user as argument
Rule: DS-0002
(IaC/Dockerfile)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@must-gather/Dockerfile` around lines 1 - 2, The Dockerfile lacks a USER
directive, which means the container will run as root by default. Add a USER
directive with a non-root user (such as `nobody`, `1000`, or another dedicated
application user) before the final CMD statement at the end of the Dockerfile to
ensure the container runs with appropriate security constraints and least
privilege access.
Sources: Path instructions, Linters/SAST tools
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5c3b3c6 to
4fe45c0
Compare
4fe45c0 to
7d74a51
Compare
|
/lgtm |
7d74a51 to
16d6e5b
Compare
|
/lgtm |
16d6e5b to
e944f0f
Compare
47ead46 to
c2c80a7
Compare
|
/lgtm |
…est to 7658453 release-1.4 Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
c2c80a7 to
fa2e79a
Compare
|
/lgtm |
|
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR contains the following updates:
058e4cf→7658453Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.