NO-JIRA: Update kueue-operand-main to cf985ed#2102
Conversation
|
@red-hat-konflux[bot]: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
WalkthroughTwo JSON image manifest files update the ChangesOperand Image Digest Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@related_images.developer.json`:
- Line 12: The operand image reference in related_images.developer.json includes
a trailing space, which gets propagated into the generated CSV by the
bundle.Dockerfile flow. Remove the whitespace from the image value so the string
is a valid image reference. Use the related_images.developer.json entry for the
kueue-operand-main image as the target to fix.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: e85679c4-ad98-4cbb-a890-11718f3f5514
📒 Files selected for processing (2)
related_images.developer.jsonrelated_images.json
| { | ||
| "name": "operand", | ||
| "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-operand-main@sha256:1ec066f622ce80f60ab7d5d0544cbaca00541fe0e9a8102299100303e519622a " | ||
| "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-operand-main@sha256:9a59c3de1aa869ee0e299d6aa9f845a94ebc76706ec77fc5f72e7969775a7bdf " |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Remove the trailing space from the operand image reference.
That whitespace is part of the JSON value, so bundle.developer.Dockerfile:10 will inject an invalid image string into the generated CSV.
Proposed fix
- "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-operand-main@sha256:9a59c3de1aa869ee0e299d6aa9f845a94ebc76706ec77fc5f72e7969775a7bdf "
+ "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-operand-main@sha256:9a59c3de1aa869ee0e299d6aa9f845a94ebc76706ec77fc5f72e7969775a7bdf"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-operand-main@sha256:9a59c3de1aa869ee0e299d6aa9f845a94ebc76706ec77fc5f72e7969775a7bdf " | |
| "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-operand-main@sha256:9a59c3de1aa869ee0e299d6aa9f845a94ebc76706ec77fc5f72e7969775a7bdf" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@related_images.developer.json` at line 12, The operand image reference in
related_images.developer.json includes a trailing space, which gets propagated
into the generated CSV by the bundle.Dockerfile flow. Remove the whitespace from
the image value so the string is a valid image reference. Use the
related_images.developer.json entry for the kueue-operand-main image as the
target to fix.
Image created from 'https://github.com/openshift/kueue-operator?rev=88e9987f98ee9da7705b3e0bf0e7403206d50fef' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
43af89a to
7a32063
Compare
|
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@related_images.developer.json`:
- Around line 4-8: The image references in related_images.developer.json still
have trailing spaces, which will propagate into the generated bundle. Remove the
extra whitespace from the operator and must-gather image values in the
related_images entries so bundle.developer.Dockerfile reads clean references via
jq -r and writes valid CSV image references.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 543084db-ee28-4699-ad00-30070375f305
📒 Files selected for processing (2)
related_images.developer.jsonrelated_images.json
✅ Files skipped from review due to trivial changes (1)
- related_images.json
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@related_images.developer.json`:
- Around line 4-8: The image references in related_images.developer.json still
have trailing spaces, which will propagate into the generated bundle. Remove the
extra whitespace from the operator and must-gather image values in the
related_images entries so bundle.developer.Dockerfile reads clean references via
jq -r and writes valid CSV image references.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 543084db-ee28-4699-ad00-30070375f305
📒 Files selected for processing (2)
related_images.developer.jsonrelated_images.json
✅ Files skipped from review due to trivial changes (1)
- related_images.json
🛑 Comments failed to post (1)
related_images.developer.json (1)
4-8: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Remove the trailing spaces from the other image references.
Line 4 and Line 8 still include a trailing space.
bundle.developer.Dockerfilereads these values verbatim withjq -rand writes them into the CSV withsed, so the generated bundle will carry invalidoperatorandmust-gatherimage references too.Proposed fix
- "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-operator-main@sha256:3b035012a3318d168b07d8f1e3e4768be76bc70acc59ce0d44f554d3800fade0 " + "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-operator-main@sha256:3b035012a3318d168b07d8f1e3e4768be76bc70acc59ce0d44f554d3800fade0" … - "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-must-gather-main@sha256:3d66452b179687927aa610b1d2df7f96df6e6bbc356f8e2869b6f99831590f1c " + "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-must-gather-main@sha256:3d66452b179687927aa610b1d2df7f96df6e6bbc356f8e2869b6f99831590f1c"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements."image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-operator-main@sha256:3b035012a3318d168b07d8f1e3e4768be76bc70acc59ce0d44f554d3800fade0" }, { "name": "must-gather", "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-must-gather-main@sha256:3d66452b179687927aa610b1d2df7f96df6e6bbc356f8e2869b6f99831590f1c"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@related_images.developer.json` around lines 4 - 8, The image references in related_images.developer.json still have trailing spaces, which will propagate into the generated bundle. Remove the extra whitespace from the operator and must-gather image values in the related_images entries so bundle.developer.Dockerfile reads clean references via jq -r and writes valid CSV image references.
|
@red-hat-konflux[bot]: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Image created from 'https://github.com/openshift/kueue-operator?rev=88e9987f98ee9da7705b3e0bf0e7403206d50fef'
This PR contains the following updates:
1ec066f->cf985edConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
To execute skipped test pipelines write comment
/ok-to-testSummary by CodeRabbit