[WIP] fixing e2e test#1797
Conversation
|
/hold |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
… regenerate bundle The bundle CRD was stale — missing agenticConsole and alertsAdapter fields added by OLS-3236 and OLS-3348. Because these fields were value types (not pointers), Go's omitempty did not suppress them, causing "unknown field" warnings in CI and a CRD/operator mismatch that broke all bundle e2e tests. - Change AgenticConsoleContainer and AlertsAdapter to pointer types in DeploymentConfig - Add nil guards at all production-code access sites - Initialize pointers in tests before sub-field access - Regenerate deepcopy, CRD manifests, and operator bundle Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@raptorsun: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
AgenticConsoleContainerandAlertsAdapterfrom value types to pointer types inDeploymentConfigThe bundle CRD (
bundle/manifests/ols.openshift.io_olsconfigs.yaml) was stale — missingagenticConsoleandalertsAdapterfields added by OLS-3236 and OLS-3348. Because these fields were Go value types (not pointers),omitemptydid not suppress them, causing "unknown field" warnings in CI and a CRD/operator mismatch that broke all bundle e2e tests.Test plan
make test— all unit tests pass🤖 Generated with Claude Code