Skip to content

[WIP] fixing e2e test#1797

Open
raptorsun wants to merge 1 commit into
openshift:mainfrom
raptorsun:e2e-fix
Open

[WIP] fixing e2e test#1797
raptorsun wants to merge 1 commit into
openshift:mainfrom
raptorsun:e2e-fix

Conversation

@raptorsun

@raptorsun raptorsun commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Change AgenticConsoleContainer and AlertsAdapter from value types to pointer types in DeploymentConfig
  • Add nil guards at all production-code access sites
  • Regenerate deepcopy, CRD manifests, and operator bundle

The bundle CRD (bundle/manifests/ols.openshift.io_olsconfigs.yaml) was stale — missing agenticConsole and alertsAdapter fields added by OLS-3236 and OLS-3348. Because these fields were Go value types (not pointers), omitempty did not suppress them, causing "unknown field" warnings in CI and a CRD/operator mismatch that broke all bundle e2e tests.

Test plan

  • make test — all unit tests pass
  • Bundle e2e CI passes with updated CRD

🤖 Generated with Claude Code

@raptorsun

Copy link
Copy Markdown
Contributor Author

/hold

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • WIP
  • DO NOT MERGE

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 667f5f82-6ebc-4106-be21-0d56dab0b3ce

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 8, 2026
@openshift-ci openshift-ci Bot requested review from blublinsky and joshuawilson July 8, 2026 09:04
@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshuawilson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… regenerate bundle

The bundle CRD was stale — missing agenticConsole and alertsAdapter fields added
by OLS-3236 and OLS-3348. Because these fields were value types (not pointers),
Go's omitempty did not suppress them, causing "unknown field" warnings in CI and
a CRD/operator mismatch that broke all bundle e2e tests.

- Change AgenticConsoleContainer and AlertsAdapter to pointer types in DeploymentConfig
- Add nil guards at all production-code access sites
- Initialize pointers in tests before sub-field access
- Regenerate deepcopy, CRD manifests, and operator bundle

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2026
@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown

@raptorsun: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant