OCPNODE-3720: Add a test for NodeSizing default change to OCP 4.21 (With cleanup fix) #5470
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@ngopalak-redhat: This pull request references OCPNODE-3720 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.21.0" version, but multiple target versions were set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ngopalak-redhat The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test all |
|
@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/52c26440-d457-11f0-8744-fee139f44aaa-0 |
|
/test all |
|
@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9f890340-d4ae-11f0-9346-83e4378c2c81-0 |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive |
|
@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5774e700-d4df-11f0-918c-2fe52561a113-0 |
ngopalak-redhat
force-pushed
the
ngopalak/node-sizing-test-mco
branch
from
b562a59 to
69874f7
Compare
|
@ngopalak-redhat: This pull request references OCPNODE-3720 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.21.0" version, but multiple target versions were set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ngopalak-redhat: This pull request references OCPNODE-3720 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.21.0" version, but multiple target versions were set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive |
|
@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7ea60cb0-d565-11f0-856b-de8ef39153c1-0 |
ngopalak-redhat
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ngopalak-redhat
changed the title
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive |
|
@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb188490-d5aa-11f0-85aa-01eb8f6f1f96-0 |
|
/retest-required |
|
@isabella-janssen Thanks for the review. I have addressed the comments. Waiting for tests to complete |
|
/retest-required |
|
/hold Holding while team MCO takes the time to develop a consensus on how to handle tests such as these. |
openshift-ci
bot
added
the
do-not-merge/hold
|
@ngopalak-redhat: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| mcpPoolLabel = "machineconfiguration.openshift.io/pool" | ||
| ) | ||
|
|
||
| var _ = g.Describe("[sig-mco][Suite:openshift/machine-config-operator/disruptive][Serial] Node sizing", func() { |
There was a problem hiding this comment.
Thank you for the fixups. The MCO team has just had a discussion on this, and we believe that these tests should live in a new test suite. Adding additional non-MCO managed tests increases the chances of inter-test conflicts, and also limits our already-stretched test timeout capacity. In this case, we suggest:
- create a new suite (perhaps openshift/node/disruptive or similar)
- create the corresponding jobs to exercise the suite (it doesn't look like we're using this for feature promotion, just automated testing, so perhaps 1-2 jobs is fine, vs the current MCO FG tests which run in 14 jobs)
- move this back to the origin repo and attach sig-node to the list
4 participants
- What I did
The PR was reverted from origin: openshift/origin#30465 due to regression openshift/origin#30465 (comment). Re-adding to the test suite with cleanup code.
Added test for the dev work in OCPNODE-3719
The e2e Jira is OCPNODE-3720
Adds a test to make sure that node sizing enabled is set correctly on the node. The test is written in similar lines to 4.20 PR: openshift/origin#30467
This PR introduces a new E2E test case to verify the behavior of the NODE_SIZING_ENABLED feature flag following the changes in #5390. The primary goal is to ensure that while the patch introduces a new MachineConfig, it does not automatically disable a user's ability to disable node autosizing for reserved resources.
NOTE: [Suite:openshift/machine-config-operator/disruptive] will ensure that the container restart failures are not recorded for this test. Its a common pattern used for machine config tests.
- How to verify it
Using Periodic disruptive runs
- Description for the changelog
Added e2e test for the Node Sizing feature