-
Notifications
You must be signed in to change notification settings - Fork 221
USHIFT-6358: Fix CoreDNS flaky test #5851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@pacevedom: This pull request references USHIFT-6358 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
|
/test all |
|
The dual-stack scenarios seem to be flaking. In some cases, the scenario times out while waiting for the VM's ip addr. In others, the scenario creates but the test fails because there isn't an IPv6 addr. |
2f20708 to
952b0d1
Compare
|
/hold cancel |
| scenario_run_tests() { | ||
| run_tests host1 \ | ||
| --variable "EXPECTED_OS_VERSION:9.6" \ | ||
| --variable "SYNC_FREQUENCY:5s" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add a comment on why we pass sync frequency in this specific test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| scenario_run_tests() { | ||
| run_tests host1 \ | ||
| --variable "EXPECTED_OS_VERSION:9.6" \ | ||
| --variable "SYNC_FREQUENCY:5s" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add a comment on why we pass sync frequency in this specific test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
/lgtm |
1a2cb46 to
54ead95
Compare
54ead95 to
2d015db
Compare
|
Reapplying LGTM after a minor fix in comments |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pacevedom, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-tests |
|
/verified by ci |
|
@ggiguash: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.