chore(deps): update module gopkg.in/yaml.v2 to v3 - #296
chore(deps): update module gopkg.in/yaml.v2 to v3#296red-hat-konflux-kflux-prd-rh03[bot] wants to merge 1 commit into
Conversation
|
Hi @red-hat-konflux-kflux-prd-rh03[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 65.39% 65.39%
=======================================
Files 23 23
Lines 1598 1598
=======================================
Hits 1045 1045
Misses 473 473
Partials 80 80 🚀 New features to boost your workflow:
|
a60b780 to
f12693f
Compare
f12693f to
50ea4fe
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux-kflux-prd-rh03[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux-kflux-prd-rh03[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
50ea4fe to
36718b0
Compare
|
🤖 Finished Retro · ✅ Success · Started 8:04 PM UTC · Completed 8:17 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $4.38 |
Retro: PR #296 — Renovate
|
Signed-off-by: red-hat-konflux-kflux-prd-rh03 <206760901+red-hat-konflux-kflux-prd-rh03[bot]@users.noreply.github.com>
36718b0 to
aa64107
Compare
|
🤖 Finished Review · ✅ Success · Started 4:12 AM UTC · Completed 4:25 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.22 |
ReviewFindingsHigh
Low
Next steps:
|
| go.yaml.in/yaml/v2 v2.4.4 // indirect | ||
| go.yaml.in/yaml/v3 v3.0.4 // indirect | ||
| gopkg.in/evanphx/json-patch.v4 v4.13.0 // indirect | ||
| gopkg.in/yaml.v2 v2.4.0 // indirect |
There was a problem hiding this comment.
[high] logic-error
The PR title claims to 'update module gopkg.in/yaml.v2 to v3', but the actual diff only moves the gopkg.in/yaml.v2 v2.4.0 line from one require block to another within go.mod. No version update occurs — the dependency remains at v2.4.0. In Go modules, gopkg.in/yaml.v2 and gopkg.in/yaml.v3 are distinct module paths; a genuine upgrade requires changing all import statements in .go files, adapting to API differences, and removing the v2 dependency. gopkg.in/yaml.v3 v3.0.1 was already present before this PR. The change as written is a no-op with no functional effect.
Suggested fix: Either (a) close this PR since it does not accomplish what it claims, or (b) perform the actual yaml.v2-to-v3 migration: update transitive dependencies, change import paths in source files, adapt to yaml.v3 API differences, remove the yaml.v2 require line, and run go mod tidy.
This PR contains the following updates:
v2.4.0→v3.0.1Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
go-yaml/yaml (gopkg.in/yaml.v2)
v3.0.1Compare Source
v3.0.0Compare Source
Configuration
📅 Schedule: (in timezone UTC)
* 2-4 * * 1-5)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.