Skip to content

OCPBUGS-90079: Updated the MCP Server examples with multiple fixes#113895

Open
dfitzmau wants to merge 1 commit into
openshift:mainfrom
dfitzmau:OCPBUGS-90079
Open

OCPBUGS-90079: Updated the MCP Server examples with multiple fixes#113895
dfitzmau wants to merge 1 commit into
openshift:mainfrom
dfitzmau:OCPBUGS-90079

Conversation

@dfitzmau

@dfitzmau dfitzmau commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Version(s):
4.22+

Issue:
OCPBUGS-90079

Link to docs preview:

  • SME has approved this change (Yiyong He).
  • QE has approved this change (Michal Vinkler).

#111327

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 23, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@dfitzmau: This pull request references Jira Issue OCPBUGS-90079, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Version(s):
4.16+

Issue:
OCPBUGS-90079

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau added branch/enterprise-4.22 branch/enterprise-5.0 and removed jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 23, 2026
@openshift-ci-robot openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Jun 23, 2026
@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 23, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 23, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@dfitzmau: This pull request references Jira Issue OCPBUGS-90079, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Version(s):
4.22+

Issue:
OCPBUGS-90079

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot

ocpdocs-previewbot commented Jun 23, 2026

Copy link
Copy Markdown

🤖 Tue Jun 23 13:48:37 - Prow CI generated the docs preview:

https://113895--ocpdocs-pr.netlify.app/openshift-enterprise/latest/ai_applications/mcp_server/mcp-server-overview.html

Comment thread modules/ai-app-mcp-server-verify-deployment.adoc Outdated
@dfitzmau dfitzmau force-pushed the OCPBUGS-90079 branch 2 times, most recently from e31dabf to 37432f5 Compare June 23, 2026 09:50
@SirVL

SirVL commented Jun 23, 2026

Copy link
Copy Markdown

Thanks for working on this update. I think a few issues still need to be adjusted before this PR can be merged.

  1. The namespace changes still look inconsistent with the Jira requirement. The Jira says: “The openshift-mcp-server namespace is separate and must remain unchanged for the MCP Server, its HTTPRoute, and its MCPServerRegistration.”
    So I think the fix should be:

    • Keep openshift-mcp-server unchanged for the MCP Server side.
    • Normalize the Gateway-side namespaces gateway-namespace, gateway-system, and mcp-system to gateway-namespace.
  2. Some verification commands still appear to use the old namespace mcp-system, for example:

    oc logs -n mcp-system deployment/mcp-gateway
    oc get pods -n mcp-system -l "app.kubernetes.io/name=mcp-gateway"

    These should be updated to use gateway-namespace.

  3. The Helm repo add/update steps seem to have been added to the verification section. They should be placed in section 1.1.6.1. Installing the MCP Server Helm chart, before step 1, because the openshift-helm-charts repo alias must exist before the documented Helm installation command can reference openshift-helm-charts/redhat-openshift-mcp-server.

  4. The oc get mcpgatewayextension -A example output still looks incorrect. It looks like the value that should have been changed is the NAMESPACE value from mcp-system to gateway-namespace, but the PR changed the NAME value from mcp-gateway to gateway-namespace instead. The NAME should remain mcp-gateway, and the namespace should be updated to gateway-namespace.

Could you please check these points?

@dfitzmau dfitzmau force-pushed the OCPBUGS-90079 branch 2 times, most recently from 7b0333a to 73e0658 Compare June 23, 2026 12:07
@SirVL

SirVL commented Jun 23, 2026

Copy link
Copy Markdown

LGTM

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot

Copy link
Copy Markdown

@dfitzmau: This pull request references Jira Issue OCPBUGS-90079, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Version(s):
4.22+

Issue:
OCPBUGS-90079

Link to docs preview:

  • SME has approved this change (Yiyong He).
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.22 branch/enterprise-5.0 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants