OCPBUGS-84512: Remove exception terminationMessagePolicy=TerminationMessageFallbackToLogsOnError by theobarberbany · Pull Request #31327 · openshift/origin

theobarberbany · 2026-06-23T11:13:07Z

Removes the exception for cloud-provider-aws on terminationMessagePolicy=FallbackToLogsOnError violations

Summary by CodeRabbit

Bug Fixes
- Stricter validation enforcement: Removed grandfathered exceptions for a namespace, ensuring TerminationMessagePolicy violations are now properly reported and cannot bypass validation checks.

…essageFallbackToLogsOnError Removes the exception for cloud-provider-aws on terminationMessagePolicy=FallbackToLogsOnError violations

openshift-merge-bot · 2026-06-23T11:13:09Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci-robot · 2026-06-23T11:13:09Z

@theobarberbany: No Jira issue with key CPBUGS-84512 exists in the tracker at https://redhat.atlassian.net.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Removes the exception for cloud-provider-aws on terminationMessagePolicy=FallbackToLogsOnError violations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-06-23T11:13:23Z

@theobarberbany: This pull request references Jira Issue OCPBUGS-84512, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Removes the exception for cloud-provider-aws on terminationMessagePolicy=FallbackToLogsOnError violations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

theobarberbany · 2026-06-23T11:13:24Z

/jira refresh

openshift-ci-robot · 2026-06-23T11:13:29Z

@theobarberbany: This pull request references Jira Issue OCPBUGS-84512, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-06-23T11:13:32Z

Walkthrough

The openshift-cloud-controller-manager namespace entry is removed from the existingViolations grandfathered exceptions map in the termination message policy monitor test, meaning pods in that namespace are no longer exempt from TerminationMessagePolicy violation reporting. A minor block layout adjustment is also made to the ephemeralContainers loop.

Changes

Remove CCM namespace from termination message policy exemptions

Layer / File(s)	Summary
Remove CCM exemption and loop formatting `pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go`	Deletes the `openshift-cloud-controller-manager` entry from `existingViolations`, removing its grandfathered exemption from `TerminationMessagePolicy` checks. Adjusts `ephemeralContainers` loop block spacing with no logic change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing an exception for terminationMessagePolicy violations in the openshift-cloud-controller-manager namespace, which aligns with the code changes shown in the diff.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only removes entries from existingViolations map and makes no changes to test name generation code. The existing test names use static Kubernetes namespace names (e.g., openshift-cluster-version...
Test Structure And Quality	✅ Passed	The PR modifies monitortest.go (monitor test implementation) and monitortest_test.go (Go unit test using testing package). Neither contains Ginkgo tests, so the Ginkgo test quality check is not app...
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. The changes only modify validation logic in an existing monitor test (not an e2e test), specifically removing an exception entry from the existingViola...
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies a monitor test framework file, not a Ginkgo e2e test. The custom check only applies to new Ginkgo e2e tests (It(), Describe(), etc.), which are not present in this PR.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only removes an exception from a monitor test file; no deployment manifests, operator code, or scheduling constraints are introduced or modified.
Ote Binary Stdout Contract	✅ Passed	PR removes 3 lines (2 blank lines and 1 map entry) with no fmt.Print*, log.Print, or klog stdout writes in init() or process-level code. OTE stdout contract satisfied.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds no Ginkgo e2e tests; it modifies a monitoring test framework component that implements monitortestframework.MonitorTest, not Ginkgo test patterns.
No-Weak-Crypto	✅ Passed	The PR modifies only a monitoring/testing file for Kubernetes pod configuration validation. It contains no cryptographic code, weak crypto algorithms, or related security patterns.
Container-Privileges	✅ Passed	PR modifies a monitoring test file to remove an exception from a grandfathered violations map. No container privilege configurations (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPriv...
No-Sensitive-Data-In-Logs	✅ Passed	No sensitive data (passwords, tokens, API keys, PII, etc.) is logged. PR only removes an exception entry and formatting; no new logging statements introducing sensitive data.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

theobarberbany · 2026-06-23T11:13:56Z

/jira refresh

openshift-ci-robot · 2026-06-23T11:14:03Z

@theobarberbany: This pull request references Jira Issue OCPBUGS-84512, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

miyadav · 2026-06-23T11:20:43Z

/approve

openshift-merge-bot · 2026-06-23T11:48:38Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

theobarberbany · 2026-06-23T12:33:42Z

/pipeline auto

openshift-merge-bot · 2026-06-23T12:33:50Z

The /pipeline auto command is only available for LGTM-mode repositories. For repositories in automatic mode, second-stage tests are already triggered automatically.

miyadav · 2026-06-23T12:34:46Z

/lgtm

openshift-ci · 2026-06-23T12:35:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miyadav, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [miyadav]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

miyadav · 2026-06-23T15:50:17Z

/test e2e-gcp-ovn

theobarberbany · 2026-06-24T12:03:51Z

@miyadav The GCP failures are unrelated to this change, can we override?

miyadav · 2026-06-24T12:47:47Z

/override e2e-gcp-ovn

openshift-ci · 2026-06-24T12:50:02Z

@miyadav: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

e2e-gcp-ovn

Only the following failed contexts/checkruns were expected:

CodeRabbit
ci/prow/e2e-aws-csi
ci/prow/e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-microshift
ci/prow/e2e-aws-ovn-microshift-serial
ci/prow/e2e-aws-ovn-serial-1of2
ci/prow/e2e-aws-ovn-serial-2of2
ci/prow/e2e-gcp-csi
ci/prow/e2e-gcp-ovn
ci/prow/e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-vsphere-ovn
ci/prow/e2e-vsphere-ovn-upi
ci/prow/go-verify-deps
ci/prow/images
ci/prow/lint
ci/prow/okd-scos-images
ci/prow/unit
ci/prow/verify
ci/prow/verify-deps
pull-ci-openshift-origin-main-e2e-aws-csi
pull-ci-openshift-origin-main-e2e-aws-ovn-fips
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2
pull-ci-openshift-origin-main-e2e-gcp-csi
pull-ci-openshift-origin-main-e2e-gcp-ovn
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-origin-main-e2e-vsphere-ovn
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi
pull-ci-openshift-origin-main-go-verify-deps
pull-ci-openshift-origin-main-images
pull-ci-openshift-origin-main-lint
pull-ci-openshift-origin-main-okd-scos-images
pull-ci-openshift-origin-main-unit
pull-ci-openshift-origin-main-verify
pull-ci-openshift-origin-main-verify-deps
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

miyadav · 2026-06-24T12:50:07Z

/override ci/prow/e2e-gcp-ovn

openshift-ci · 2026-06-24T12:52:19Z

@miyadav: Overrode contexts on behalf of miyadav: ci/prow/e2e-gcp-ovn

Details

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-06-24T12:53:00Z

@theobarberbany: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

OCPBUGS-84512: Remove exception terminationMessagePolicy=TerminationM…

e9bc246

…essageFallbackToLogsOnError Removes the exception for cloud-provider-aws on terminationMessagePolicy=FallbackToLogsOnError violations

theobarberbany changed the title ~~CPBUGS-84512: Remove exception terminationMessagePolicy=TerminationMessageFallbackToLogsOnError~~ OCPBUGS-84512: Remove exception terminationMessagePolicy=TerminationMessageFallbackToLogsOnError Jun 23, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 23, 2026

openshift-ci Bot requested review from deads2k and sjenning June 23, 2026 11:14

coderabbitai Bot approved these changes Jun 23, 2026

View reviewed changes

openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 23, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2026

openshift-ci Bot assigned miyadav Jun 23, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2026

Conversation

theobarberbany commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Jun 23, 2026

Uh oh!

openshift-ci-robot commented Jun 23, 2026

Uh oh!

openshift-ci-robot commented Jun 23, 2026

Uh oh!

theobarberbany commented Jun 23, 2026

Uh oh!

openshift-ci-robot commented Jun 23, 2026

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

theobarberbany commented Jun 23, 2026

Uh oh!

openshift-ci-robot commented Jun 23, 2026

Uh oh!

miyadav commented Jun 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 23, 2026

Uh oh!

theobarberbany commented Jun 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 23, 2026

Uh oh!

miyadav commented Jun 23, 2026

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

miyadav commented Jun 23, 2026

Uh oh!

theobarberbany commented Jun 24, 2026

Uh oh!

miyadav commented Jun 24, 2026

Uh oh!

openshift-ci Bot commented Jun 24, 2026

Uh oh!

miyadav commented Jun 24, 2026

Uh oh!

openshift-ci Bot commented Jun 24, 2026

Uh oh!

openshift-ci Bot commented Jun 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

theobarberbany commented Jun 23, 2026 •

edited

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading