SDCICD-1735: update krknai prompt and markdown-to-HTML conversion by minlei98 · Pull Request #3128 · openshift/osde2e

minlei98 · 2026-02-26T16:19:14Z

Update Krknai.yaml prompt
Add MergeTemplates to PromptStore for loading package-local templates on top of defaults.
Add markdown-to-HTML conversion for --report-format=html in the krkn-ai engine
keeping the default osde2e analyzer unchanged.

openshift-ci-robot · 2026-02-26T16:19:17Z

There are test jobs defined for this repository which are not configured to run automatically. Comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger jobs most likely to be impacted by the proposed changes.Comment /pipeline required to trigger all required & necessary jobs.

openshift-ci-robot · 2026-02-26T16:19:19Z

@minlei98: This pull request references SDCICD-1735 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Update Krknai.yaml prompt

Add MergeTemplates to PromptStore for loading package-local templates on top of defaults.

Add markdown-to-HTML conversion for --report-format=html in the krkn-ai engine

keeping the default osde2e analyzer unchanged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-02-26T16:19:51Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minlei98
Once this PR has been reviewed and has the lgtm label, please assign yiqinzhang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/krknai/analysisengine/engine.go

pkg/krknai/analysisengine/prompts/krknai.yaml

minlei98 · 2026-02-26T19:06:10Z

krknai-22report.html
Report with cluster info

ritmun · 2026-02-26T21:53:06Z

pkg/krknai/analysisengine/engine.go

+func markdownToHTML(content string) string {
+	htmlTemplate, err := krknPrompts.ReadFile(htmlTemplatePath)
+	if err != nil {
+		return content


should this return or log an error?

varunraokadaparthi · 2026-02-27T16:51:08Z

pkg/krknai/analysisengine/engine.go

 	return nil
 }

+func markdownToHTML(content string) string {


We could use LLM to generate HTML using --report-format in the prompt with a condition.
But to save tokens and keep better control, we can handle the HTML conversion ourselves.

might be worth a try if it would remove 3 dependencies

"github.com/gomarkdown/markdown" mdhtml "github.com/gomarkdown/markdown/html" "github.com/gomarkdown/markdown/parser"

Q: how does the prompt way consume more tokens?

Agree, use our own HTML conversion, we could control the output better.

internal/prompts/prompts.go

openshift-ci · 2026-02-27T20:56:37Z

@minlei98: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ritmun · 2026-03-02T14:42:45Z

pkg/krknai/analysisengine/prompts/krknai.yaml

+  ## Executive Summary (2-3 sentences)
+  ## Cluster Under Test (ID, name, version, type, provider, region, hypershift yes/no)
+  ## Test Configuration (GA params, scenarios, health check targets)
+  ## Run Statistics (table: totals, generations, fitness scores, types)


The sample html here doesn't show fitness function used. Could you add that?

ritmun · 2026-03-02T14:57:39Z

pkg/krknai/analysisengine/prompts/krknai.yaml

+  ## Test Configuration (GA params, scenarios, health check targets)
+  ## Run Statistics (table: totals, generations, fitness scores, types)
+  ## Genetic Algorithm Evolution (fitness trends, convergence, most disruptive generation)
+  ## Top Vulnerabilities (top 3-5 by fitness: target, impact, severity [Critical/High/Medium/Low], why it matters)


Is there a way to include information about type of node (eg infra) in case of "Node CPU Hog" vulnerability?

iamkirkbater · 2026-03-02T15:09:02Z

The generated HTML file is really nice. Super easy to read, straight to the point. Almost doesn't even read like it's generated by AI :D

The only thing I could potentially ask to add would be that somewhere in that file there's a link, or a reference to how I would figure out where the must-gather is for that run. Specifically - in the generated HTML document it references a node that caused the highest fitness score. However, without knowing any more details of that node I don't know what to do with that information. I assume that it was an infra node, but without being able to know what workloads were on it I can't really do much with the information this report generated.

That's my only "problem" with this - and I use the term "problem" very loosely. This is amazing!

ritmun · 2026-03-02T15:20:20Z

pkg/krknai/analysisengine/prompts/report.html

+<html lang="en">
+<head>
+<meta charset="UTF-8">
+<meta name="viewport" content="width=device-width, initial-scale=1.0">


Suggested change

<meta name="viewport" content="width=device-width, initial-scale=1.0">

<meta name="viewport" content="width=device-width, initial-scale=1.0">

<meta http-equiv="Content-Security-Policy" content="default-src 'self'">

Claude: The HTML template includes inline styles but no CSP (Content Security Policy) headers. While this is a static report, if it's ever served over HTTP, it could benefit from security headers.

ritmun · 2026-03-02T15:24:16Z

pkg/krknai/analysisengine/engine.go

+	p := parser.NewWithExtensions(parser.CommonExtensions | parser.AutoHeadingIDs)
+	renderer := mdhtml.NewRenderer(mdhtml.RendererOptions{Flags: mdhtml.CommonFlags | mdhtml.HrefTargetBlank})
+	body := markdown.ToHTML([]byte(content), p, renderer)
+	return fmt.Sprintf(string(htmlTemplate), string(body)), nil


should use template parser here like this one

Claude: Fix HTML injection vulnerability - Use html/template instead of fmt.Sprintf

ritmun · 2026-03-02T15:31:37Z

pkg/krknai/analysisengine/engine.go

-	TopScenariosCount int // Number of top scenarios to include (default: 10)
+	TopScenariosCount int                         // Number of top scenarios to include (default: 10)
+	ReportFormat      string                      // "json" (default), "markdown", or "html"
+	ClusterInfo       *analysisengine.ClusterInfo // Cluster metadata from CLI flags


Could you get ClusterInfo directly from Collector? Then you don't need that variable here at all and can pass just the collected data to template.

osde2e/pkg/krknai/aggregator/aggregator.go

Line 93 in c2744e8

func (a *KrknAIAggregator) Collect(ctx context.Context, resultsDir string) (*KrknAIData, error) {

ritmun · 2026-03-02T15:37:37Z

Specifically - in the generated HTML document it references a node that caused the highest fitness score. However, without knowing any more details of that node I don't know what to do with that information

Thanks for the suggestion! Created card https://issues.redhat.com/browse/SDCICD-1766

ritmun · 2026-03-02T16:37:39Z

krknai-22report.html Report with cluster info

Can we add environment and remove cluster name?
Cluster Type can combine - cloud provider (AWS/GCP), ocp type (ROSA/OSD) and hypershift (if hcp)

minlei98 · 2026-03-02T20:34:08Z

krknai-49report.html
Here is the latest report with last week's test result.

ritmun · 2026-03-02T20:38:40Z

Can we increase the font size for this highlighted code style to normal size?

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2026

openshift-ci bot requested review from YiqinZhang and varunraokadaparthi February 26, 2026 16:19

ritmun reviewed Feb 26, 2026

View reviewed changes

pkg/krknai/analysisengine/engine.go Outdated Show resolved Hide resolved

ritmun reviewed Feb 26, 2026

View reviewed changes

pkg/krknai/analysisengine/prompts/krknai.yaml Outdated Show resolved Hide resolved

ritmun reviewed Feb 26, 2026

View reviewed changes

pkg/krknai/analysisengine/prompts/krknai.yaml Show resolved Hide resolved

ritmun reviewed Feb 26, 2026

View reviewed changes

pkg/krknai/analysisengine/prompts/krknai.yaml Show resolved Hide resolved

minlei98 force-pushed the SDCICD-1735 branch 2 times, most recently from 22b5db7 to f5cd52d Compare February 26, 2026 21:04

ritmun reviewed Feb 26, 2026

View reviewed changes

varunraokadaparthi reviewed Feb 27, 2026

View reviewed changes

internal/prompts/prompts.go Outdated Show resolved Hide resolved

update krknai prompt and markdown-to-HTML conversion

a66b16a

minlei98 force-pushed the SDCICD-1735 branch from f5cd52d to a66b16a Compare February 27, 2026 20:48

ritmun reviewed Mar 2, 2026

View reviewed changes

	<meta name="viewport" content="width=device-width, initial-scale=1.0">
	<meta name="viewport" content="width=device-width, initial-scale=1.0">
	<meta http-equiv="Content-Security-Policy" content="default-src 'self'">

Conversation

minlei98 commented Feb 26, 2026

Uh oh!

openshift-ci-robot commented Feb 26, 2026

Uh oh!

openshift-ci-robot commented Feb 26, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Feb 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

minlei98 commented Feb 26, 2026

Uh oh!

ritmun Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

varunraokadaparthi Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

ritmun Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

minlei98 Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci bot commented Feb 27, 2026

Uh oh!

ritmun Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ritmun Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamkirkbater commented Mar 2, 2026

Uh oh!

ritmun Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

ritmun Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

ritmun Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

ritmun commented Mar 2, 2026

Uh oh!

ritmun commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

minlei98 commented Mar 2, 2026

Uh oh!

ritmun commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci-robot commented Feb 26, 2026 •

edited by openshift-ci bot

Loading

ritmun Feb 26, 2026 •

edited

Loading

ritmun Feb 27, 2026 •

edited

Loading

ritmun Mar 2, 2026 •

edited

Loading

ritmun Mar 2, 2026 •

edited

Loading

ritmun commented Mar 2, 2026 •

edited

Loading